[GitHub] [incubator-echarts] Ovilia edited a comment on issue #10563: Issue of the end points of edges in Graph chart

[GitBox <gi...@apache.org>]

Ovilia edited a comment on issue #10563: Issue of the end points of edges in Graph chart
URL: https://github.com/apache/incubator-echarts/issues/10563#issuecomment-497226702
 
 
   I thought it solved your problem so I added `waiting-for-author` tag, waiting for you to close or I will close it after a week if the author did not respond.
   I think `symbolOffset` is the correct way to do this, since it's designed to adjust the position of symbols.
   
   If you use SVG to render the graph, you will see the position of the edge is actually much inside the nodes and it's not a problem with symbols on the edges. 
   <img width="744" alt="屏幕快照 2019-05-30 14 49 16" src="https://user-images.githubusercontent.com/779050/58614528-3040f680-82eb-11e9-82c2-cbe8d1a250e1.png">
   
   Actually, the start and end position calculation is quite complex. You can think they lie on an arc, not considering the shape of the nodes. Because if we wish to make the edge start and end exactly on the border of the node shape, it would be a super complex way to calculate (think about collision detection algorithm).
   
   So, I think it is a good idea to keep it this way, and use `symbolOffset` to adjust as you wish.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org