You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/01 09:40:09 UTC
Review Request 37993: Add explanatory comments for Allocator interface
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Michael Park.
Bugs: MESOS-2224
https://issues.apache.org/jira/browse/MESOS-2224
Repository: mesos
Description
-------
Add explanatory comments for Allocator interface
Diffs
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
Diff: https://reviews.apache.org/r/37993/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 37993: Add explanatory comments for Allocator
interface
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review97268
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37993]
All tests passed.
- Mesos ReviewBot
On Sept. 1, 2015, 7:40 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 7:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Michael Park.
>
>
> Bugs: MESOS-2224
> https://issues.apache.org/jira/browse/MESOS-2224
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add explanatory comments for Allocator interface
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
>
> Diff: https://reviews.apache.org/r/37993/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37993: Add explanatory comments for Allocator
interface
Posted by Guangya Liu <gy...@gmail.com>.
> On 九月 1, 2015, 9:48 a.m., Alexander Rukletsov wrote:
> > That's awesome, Guangya, thanks for doing this!
> >
> > Some high-level comments before we dive into wording:
> > * We recently adopted a new style for public headers, please update the comments according to it (https://mesos.apache.org/documentation/latest/mesos-doxygen-style-guide/)
> > * We definitely need one more native speaker to review the comments. I think Adam B (adam-mesos) can be a good fit. Mind adding him to the list of reviewers?
Thanks Alex, just add adam-mesos to review list, will update the RR based on the new style.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review97270
-----------------------------------------------------------
On 九月 1, 2015, 10:03 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> -----------------------------------------------------------
>
> (Updated 九月 1, 2015, 10:03 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
>
>
> Bugs: MESOS-2224
> https://issues.apache.org/jira/browse/MESOS-2224
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add explanatory comments for Allocator interface
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
>
> Diff: https://reviews.apache.org/r/37993/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 37993: Add explanatory comments for Allocator
interface
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review97270
-----------------------------------------------------------
That's awesome, Guangya, thanks for doing this!
Some high-level comments before we dive into wording:
* We recently adopted a new style for public headers, please update the comments according to it (https://mesos.apache.org/documentation/latest/mesos-doxygen-style-guide/)
* We definitely need one more native speaker to review the comments. I think Adam B (adam-mesos) can be a good fit. Mind adding him to the list of reviewers?
- Alexander Rukletsov
On Sept. 1, 2015, 7:40 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 7:40 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Michael Park.
>
>
> Bugs: MESOS-2224
> https://issues.apache.org/jira/browse/MESOS-2224
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add explanatory comments for Allocator interface
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
>
> Diff: https://reviews.apache.org/r/37993/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>