[GitHub] [activemq-nms-amqp] lukeabsent commented on a change in pull request #70: Amqnet 723

[GitBox <gi...@apache.org>]

lukeabsent commented on a change in pull request #70:
URL: https://github.com/apache/activemq-nms-amqp/pull/70#discussion_r745678589



##########
File path: docs/configuration.md
##########
@@ -24,6 +24,7 @@ The options apply to the behavior of the NMS objects such as Connection, Session
 - **nms.clientIdPrefix** Optional prefix value that is used for generated Client ID values when a new Connection is created for the JMS ConnectionFactory. The default prefix is 'ID:'.
 - **nms.connectionIdPrefix** Optional prefix value that is used for generated Connection ID values when a new Connection is created for the JMS ConnectionFactory. This connection ID is used when logging some information from the JMS Connection object so a configurable prefix can make breadcrumbing the logs easier. The default prefix is 'ID:'.
 - **nms.maxNewConnectionRatePerSec** Allowed approximated rate for how fast connection factory is allowed to create new connection. If there is more request, they will have to wait. Default value is -1 which means unlimited.
+- **nms.maxMessageSize** Specifies maximum message size (body) to be accepted for send. If its bigger, exception may be thrown. The default value is -1 which means no limit.

Review comment:
       sure, we can try adjusting the name,
   @gemmellr I was thinking instead of using GetEstimatedMessageSize there can be custom code for estimating body size




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org