You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/13 23:57:13 UTC

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1194: [HUDI-326] Add support to delete records with only record_key

bvaradar commented on a change in pull request #1194: [HUDI-326] Add support to delete records with only record_key
URL: https://github.com/apache/incubator-hudi/pull/1194#discussion_r366088953
 
 

 ##########
 File path: hudi-spark/src/main/java/org/apache/hudi/keygen/ComplexKeyGenerator.java
 ##########
 @@ -16,8 +16,10 @@
  * limitations under the License.
  */
 
-package org.apache.hudi;
+package org.apache.hudi.keygen;
 
 Review comment:
   This is a backwards incompatible change. Users would have custom key generators using configuration : DataSourceWriteOptions.KEYGENERATOR_CLASS_OPT_KEY()
   
   It makes sense to move to separate package but we need to call out the change in release notes . Please open a tracking ticket to update release notes for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services