You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by huaxingao <gi...@git.apache.org> on 2017/11/04 09:14:54 UTC

[GitHub] spark pull request #19658: [SPARK-22443][SQL]add implementation of quoteIden...

GitHub user huaxingao opened a pull request:

    https://github.com/apache/spark/pull/19658

    [SPARK-22443][SQL]add implementation of quoteIdentifier, getTableExistsQuery and getSchemaQuery in AggregatedDialect

    …
    
    ## What changes were proposed in this pull request?
    
    override JDBCDialects methods quoteIdentifier, getTableExistsQuery and getSchemaQuery in AggregatedDialect
    
    ## How was this patch tested?
    
    Test the new implementation in JDBCSuite test("Aggregated dialects")
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huaxingao/spark spark-22443

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19658.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19658
    
----
commit 7e91d485086649c939aa21145f91728ad8c7f3de
Author: Huaxin Gao <hu...@us.ibm.com>
Date:   2017-11-04T09:04:43Z

    [SPARK-22443][SQL]add implementation of quoteIdentifier, getTableExistsQuery and getSchemaQuery in AggregatedDialect

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19658: [SPARK-22443][SQL]add implementation of quoteIdentifier,...

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/19658
  
    LGTM


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #19658: [SPARK-22443][SQL]add implementation of quoteIden...

Posted by huaxingao <gi...@git.apache.org>.

Github user huaxingao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19658#discussion_r148944273
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
    @@ -42,6 +42,18 @@ private class AggregatedDialect(dialects: List[JdbcDialect]) extends JdbcDialect
         dialects.flatMap(_.getJDBCType(dt)).headOption
       }
     
    +  override def quoteIdentifier(colName: String): String = {
    +    dialects.map(_.quoteIdentifier(colName)).head
    --- End diff --
    
    Thanks @srowen for the comment. I will change. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #19658: [SPARK-22443][SQL]add implementation of quoteIden...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19658#discussion_r148927625
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/AggregatedDialect.scala ---
    @@ -42,6 +42,18 @@ private class AggregatedDialect(dialects: List[JdbcDialect]) extends JdbcDialect
         dialects.flatMap(_.getJDBCType(dt)).headOption
       }
     
    +  override def quoteIdentifier(colName: String): String = {
    +    dialects.map(_.quoteIdentifier(colName)).head
    --- End diff --
    
    It's not necessary to call this on all the dialects, because only one is used. `dialects.head.quoteIdentifier(colName)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org