[GitHub] [airflow] ashb commented on issue #5908: Revert "[AIRFLOW-4797] Improve performance and behaviour of zombie de…

[GitBox <gi...@apache.org>]

ashb commented on issue #5908: Revert "[AIRFLOW-4797] Improve performance and behaviour of zombie de…
URL: https://github.com/apache/airflow/pull/5908#issuecomment-528316964
 
 
   @KevinYang21 The original PR says
   
   > The query is faster than the previous one (see also stats below).
   
   > Tested on our staging environment (patch applied to Airflow 1.10.3), zombie detection works fine, database load is unchanged. Here some stats from pg_stat_statements, the branch run there for 4 hours: The new query (1st line) is faster but is likely called more frequently. The 2nd line shows stats of the old query.
   
   > ```
   > select calls,mean_time,max_time,rows from pg_stat_statements where query like '%task_instance JOIN job%' and query like '%latest_heartbeat%';
   >   calls   |     mean_time      |  max_time   | rows 
   > ----------+--------------------+-------------+------
   >     55416 | 0.0260821553522449 |    5.509762 |   29
   >  71969011 |  0.575755060854888 | 1078.895322 | 2377
   > ```
   
   Do you get different performance behaviour?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services