You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2017/03/20 14:10:10 UTC
[GitHub] brooklyn-server pull request #599: use http://httpbin instead of https for t...
GitHub user andreaturli opened a pull request:
https://github.com/apache/brooklyn-server/pull/599
use http://httpbin instead of https for tests
this should fix the build failures we are seeing after 16th March
cc @geomacy please have a look at this
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreaturli/brooklyn-server fix/httpbin-ssl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/599.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #599
----
commit d85fc2b176175cf75096849789cd9d6ec3de0b0a
Author: Andrea Turli <an...@gmail.com>
Date: 2017-03-20T14:08:16Z
use http://httpbin instead of https for tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #599: use http://httpbin instead of https for tests
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/599
@andreaturli CompositeEffectorYamlRebindTest also uses httpbin.org, so it would need to be an integration test too. The full list looks like
- CompositeEffectorYamlRebindTest
- CompositeEffectorYamlTest
- HttpCommandEffectorYamlRebindTest
- HttpCommandEffectorYamlTest
and HttpCommandEffectorIntegrationTest which already has its tests as integration tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #599: use http://httpbin instead of https for tests
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-server/pull/599
Looks good to me but will need a couple more tests marked integration. I will merge this and do those tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #599: use http://httpbin instead of https for t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #599: use http://httpbin instead of https for tests
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/599
LGTM; waiting for jenkins to finish and then good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #599: use http://httpbin instead of https for tests
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/599
Make sure unit tests run with no internet connectivity (no DNS lookup etc). That might not be the Jenkins problem but it is a requirement of our unit tests. If you need to do an http call, run a local mock server, or make it an integration test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #599: use http://httpbin instead of https for tests
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the issue:
https://github.com/apache/brooklyn-server/pull/599
looks there is another problem with ssl in another test. Wonder if it's a jenkins issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #599: use http://httpbin instead of https for tests
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the issue:
https://github.com/apache/brooklyn-server/pull/599
I agree `@Test(groups="Integration")` is better for this test.
Notice, though, the failing tests is different this time:
org.apache.brooklyn.camp.brooklyn.CompositeEffectorYamlRebindTest.testRebindWhenHealthy (from TestSuite)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---