You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/08 21:54:35 UTC

[GitHub] [druid] suneet-s commented on a diff in pull request #12413: Improve metrics for Auto Compaction

suneet-s commented on code in PR #12413:
URL: https://github.com/apache/druid/pull/12413#discussion_r846303045


##########
server/src/main/java/org/apache/druid/server/coordinator/duty/EmitClusterStatsAndMetrics.java:
##########
@@ -513,5 +515,42 @@ private void emitStatsForCompactSegments(DruidCluster cluster, CoordinatorStats
           );
         }
     );
+
+    // Compute compaction progress as percentage

Review Comment:
   Users should be able to compute this from existing metrics. I don't think we need to emit the percentages



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org