[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #4933: [Refactor] Short circuit return to avoid meaningless loop

[GitBox <gi...@apache.org>]

acelyc111 commented on a change in pull request #4933:
URL: https://github.com/apache/incubator-doris/pull/4933#discussion_r528276457



##########
File path: be/src/olap/tablet.cpp
##########
@@ -1214,33 +1214,32 @@ void Tablet::do_tablet_meta_checkpoint() {
 
 bool Tablet::rowset_meta_is_useful(RowsetMetaSharedPtr rowset_meta) {

Review comment:
       @kangkaisen Comment added.
   
   > Why when find_version is false, the rowset is unuseful?
   
   I think you want to ask why when find_version is **true**, the rowset is unuseful. Because when version founded, means the tablet has the data in this version (maybe compacted), we can sweep up this rowset. Only when the rowset has some new data (version is not covered, i.e. find_version is false), the rowset is useful.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org