You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/07/06 14:08:32 UTC
[GitHub] storm pull request #1540: STORM-1945 Fix NPE bugs on topology spout lag for ...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1540
STORM-1945 Fix NPE bugs on topology spout lag for storm-kafka-monitor
* Fix several spots which are throwing NPE on TopologySpoutLag
* Use a trick to get classname of Spout without requiring storm-kafka and storm-kafka-client
* Move storm-kafka-monitor jar to toollib directory
* since jars in extlib are added to worker classpath which we don't want for this jar
@priyank5485 @harshach Please take a look and comment. Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1945
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1540
----
commit da387c1e3fb8d7a704c479569d7e84ce52d58e7c
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-07-06T13:49:46Z
STORM-1945 Fix NPE bugs on topology spout lag for storm-kafka-monitor
* Fix several spots which are throwing NPE on TopologySpoutLag
* Use a trick to get classname of Spout without requiring storm-kafka and storm-kafka-client
* Move storm-kafka-monitor jar to toollib directory
* since jars in extlib are added to worker classpath which we don't want for this jar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1540: STORM-1945 Fix NPE bugs on topology spout lag for storm-k...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1540
Already got +1 from 1.x branch PR and diff is same. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1540: STORM-1945 Fix NPE bugs on topology spout lag for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---