You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/19 16:54:28 UTC

[GitHub] [incubator-nuttx] v01d edited a comment on pull request #2870: Support for ESP32-C3 GPIO Driver

v01d edited a comment on pull request #2870:
URL: https://github.com/apache/incubator-nuttx/pull/2870#issuecomment-782185520


   I realized now the issue is not about different esp32c3 chips but boards. The point is that even though there are only two official boards, there will most likely be others in the future (maybe unofficial). It would be better to avoid board logic for other boards to have to copy this implementation. I think for this case the gpio lower-half is quite self-contained. Maybe it would be good to do this now and avoid copies of this file to be made by others in the future. What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org