You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-dev@incubator.apache.org by Pi...@dmr.ca on 2006/08/01 19:27:54 UTC

Hmmm... about the refactoring and code comments?

Hey,

While I was still *toying* :-)   to add a fews features in the code, It 
just occured to me that the refactoring worked quite well, but there are 
lots of comments in files that are still containing description leading to 
names prior to the refactoring. I'm guessing its because the refactoring 
feature of eclipse just plainly ignore comments lines.

Now what is yours opinion about correcting the comments in the code... 
clearly going throught it manually isn't possible, so what about the 
possibility of having it changed sporadically when files for patches / new 
features are addeds ?

Unless, somes have better suggestions?

Pierre-Luc Archambault
Fujitsu Consulting

Re: Hmmm... about the refactoring and code comments?

Posted by Mike Kienenberger <mk...@gmail.com>.
On 8/1/06, Pierre-Luc_Archambault@dmr.ca <Pi...@dmr.ca> wrote:
> names prior to the refactoring. I'm guessing its because the refactoring
> feature of eclipse just plainly ignore comments lines.

Only if you tell it to ignore them by unchecking "Update textual
matches in comments and strings" during refactoring.

Re: Re: Hmmm... about the refactoring and code comments?

Posted by Adam Winer <aw...@gmail.com>.
We can do another pass on the code to nail these kinds
of things - but anything that isn't in the public API isn't
a really big deal.

-- Adam



On 8/1/06, Matthias Wessendorf <ma...@apache.org> wrote:
> Pierre,
>
> also some constants still named like
> TrinidadPhaseListener.CACHED_ADF_FACES_CONTEXT
>
> -Matthias
>
> On 8/1/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > > Now what is yours opinion about correcting the comments in the code...
> > > clearly going throught it manually isn't possible, so what about the
> > > possibility of having it changed sporadically when files for patches / new
> > > features are addeds ?
> >
> > yeah, right. I prefer this way too.
> > There are even older Oracle based comments in some files.
> > So, when you touch a file try to fix the comments.
> >
> > Make sense ?
> >
> > > Unless, somes have better suggestions?
> > >
> > > Pierre-Luc Archambault
> > > Fujitsu Consulting
> > >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://jroller.com/page/mwessendorf
> > mail: mwessendorf-at-gmail-dot-com
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>

Re: Hmmm... about the refactoring and code comments?

Posted by Matthias Wessendorf <ma...@apache.org>.
Pierre,

also some constants still named like
TrinidadPhaseListener.CACHED_ADF_FACES_CONTEXT

-Matthias

On 8/1/06, Matthias Wessendorf <ma...@apache.org> wrote:
> > Now what is yours opinion about correcting the comments in the code...
> > clearly going throught it manually isn't possible, so what about the
> > possibility of having it changed sporadically when files for patches / new
> > features are addeds ?
>
> yeah, right. I prefer this way too.
> There are even older Oracle based comments in some files.
> So, when you touch a file try to fix the comments.
>
> Make sense ?
>
> > Unless, somes have better suggestions?
> >
> > Pierre-Luc Archambault
> > Fujitsu Consulting
> >
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>


-- 
Matthias Wessendorf

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com

Re: Hmmm... about the refactoring and code comments?

Posted by Matthias Wessendorf <ma...@apache.org>.
> Now what is yours opinion about correcting the comments in the code...
> clearly going throught it manually isn't possible, so what about the
> possibility of having it changed sporadically when files for patches / new
> features are addeds ?

yeah, right. I prefer this way too.
There are even older Oracle based comments in some files.
So, when you touch a file try to fix the comments.

Make sense ?

> Unless, somes have better suggestions?
>
> Pierre-Luc Archambault
> Fujitsu Consulting
>


-- 
Matthias Wessendorf

further stuff:
blog: http://jroller.com/page/mwessendorf
mail: mwessendorf-at-gmail-dot-com