[GitHub] [arrow-datafusion] viirya commented on pull request #6785: Consistently coerce dictionaries for arithmetic

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on PR #6785:
URL: https://github.com/apache/arrow-datafusion/pull/6785#issuecomment-1613664348

   > Therefore since this PR still supports the calculation (via casting to primitive and calling the primitive kernels) I think it doesn't undo any of that work
   
   Yea, it just casts to primitive before arithmetic operations so dictionary arrays are still going through them. From end-to-end perspective, it might be not noticeable if you don't look at the output array type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org