You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "HaochengLIU (via GitHub)" <gi...@apache.org> on 2023/03/31 01:07:03 UTC
[GitHub] [arrow] HaochengLIU opened a new issue, #34813: [C++] Add an auto fallback solution when system Gtest is cmpiled with a C++ standaard lower than 17.
HaochengLIU opened a new issue, #34813:
URL: https://github.com/apache/arrow/issues/34813
### Describe the enhancement requested
in PR https://github.com/apache/arrow/pull/34765, Arrow will error out when the detected GTest is compiled with a C++ standard lower than 17. This is a follow-up issue that should support auto fallback:
Proposed solution from @kou :
Add a FindGtestAlt.cmake file (GTestConfig.cmake is a good starting point) and use new target names to refer to suitable Arrow target. See details in this [comment](https://github.com/apache/arrow/pull/34765#discussion_r1152796004)
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] HaochengLIU commented on issue #34813: [C++] Add an auto fallback solution when system Gtest is cmpiled with a C++ standaard lower than 17.
Posted by "HaochengLIU (via GitHub)" <gi...@apache.org>.
HaochengLIU commented on issue #34813:
URL: https://github.com/apache/arrow/issues/34813#issuecomment-1492483754
yes, the goal is to support automatic fallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #34813: [C++] Add an auto fallback solution when system Gtest is cmpiled with a C++ standaard lower than 17.
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on issue #34813:
URL: https://github.com/apache/arrow/issues/34813#issuecomment-1492230816
Do you mean it would fallback to building from source?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] HaochengLIU commented on issue #34813: [C++] Add an auto fallback solution when system Gtest is cmpiled with a C++ standaard lower than 17.
Posted by "HaochengLIU (via GitHub)" <gi...@apache.org>.
HaochengLIU commented on issue #34813:
URL: https://github.com/apache/arrow/issues/34813#issuecomment-1491154638
FYI I need to tackle https://github.com/apache/arrow/issues/34565 first in April as it's related to my job. Once it's done I will revisit this enhancement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed issue #34813: [C++] Add an auto fallback solution when system Gtest is compiled with a C++ standard lower than 17.
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed issue #34813: [C++] Add an auto fallback solution when system Gtest is compiled with a C++ standard lower than 17.
URL: https://github.com/apache/arrow/issues/34813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org