You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/01/25 22:20:19 UTC
[GitHub] [superset] justinpark opened a new pull request, #22860: fix(sqllab): ignore schema validate while loading
justinpark opened a new pull request, #22860:
URL: https://github.com/apache/superset/pull/22860
### SUMMARY
This commit fixes the side effect of #22695.
The initial selected schema option has gone because the schema validator checks the existence with the empty schemaOptions before loaded.
This commit skips the validation before loaded.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/1392866/214704441-f2cc74f0-8c84-41b1-ab6b-c6ad442548a0.mov
After:
https://user-images.githubusercontent.com/1392866/214704435-c7b557dd-c575-46dd-aa3f-9dcd03e45095.mov
### TESTING INSTRUCTIONS
disable "SQLLAB_BACKEND_PERSISTENCE"
select a schema and open a new tab
check the schema preassigned from the above the schema selection
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark closed pull request #22860: fix(sqllab): ignore schema validate while loading
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark closed pull request #22860: fix(sqllab): ignore schema validate while loading
URL: https://github.com/apache/superset/pull/22860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #22860: fix(sqllab): ignore schema validate while loading
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #22860:
URL: https://github.com/apache/superset/pull/22860#issuecomment-1404328379
It makes another regression. let me close this and revert https://github.com/apache/superset/pull/22695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org