You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by Lance Norskog <go...@gmail.com> on 2012/01/05 04:16:02 UTC
code consistency
ConfusionMatrix used to use String.format() in an error message, but a
recent checkin changed it back to string + string + string. Are we not
using String.format() any more?
--
Lance Norskog
goksron@gmail.com
Re: code consistency
Posted by Sean Owen <sr...@gmail.com>.
I remember replacing something like String.format("%s", foo) with just foo
at some point -- there were no-ops and near-no-ops like this in a few
places. Maybe this is what you are talking about.
On Thu, Jan 5, 2012 at 3:16 AM, Lance Norskog <go...@gmail.com> wrote:
> ConfusionMatrix used to use String.format() in an error message, but a
> recent checkin changed it back to string + string + string. Are we not
> using String.format() any more?
>
> --
> Lance Norskog
> goksron@gmail.com
>
Re: code consistency
Posted by Lance Norskog <go...@gmail.com>.
Oops. SplitInputJob.java is DOS-mode. The test program is fine.
On Wed, Jan 4, 2012 at 7:28 PM, Ted Dunning <te...@gmail.com> wrote:
> I like format. Â YMMV.
>
> On Wed, Jan 4, 2012 at 7:16 PM, Lance Norskog <go...@gmail.com> wrote:
>
>> ConfusionMatrix used to use String.format() in an error message, but a
>> recent checkin changed it back to string + string + string. Are we not
>> using String.format() any more?
>>
>> --
>> Lance Norskog
>> goksron@gmail.com
>>
--
Lance Norskog
goksron@gmail.com
Re: code consistency
Posted by Ted Dunning <te...@gmail.com>.
I like format. YMMV.
On Wed, Jan 4, 2012 at 7:16 PM, Lance Norskog <go...@gmail.com> wrote:
> ConfusionMatrix used to use String.format() in an error message, but a
> recent checkin changed it back to string + string + string. Are we not
> using String.format() any more?
>
> --
> Lance Norskog
> goksron@gmail.com
>