You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/22 18:08:40 UTC

[GitHub] [kafka] abbccdda commented on a change in pull request #10156: KAFKA-10345 (WIP): File watch store reloading

abbccdda commented on a change in pull request #10156:
URL: https://github.com/apache/kafka/pull/10156#discussion_r580469819



##########
File path: clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java
##########
@@ -295,7 +442,7 @@ else if (keyPassword == null)
             throw new InvalidConfigurationException("SSL key store is not specified, but key store password is specified.");
         } else if (path != null && password == null) {
             throw new InvalidConfigurationException("SSL key store is specified, but key store password is not specified.");
-        } else if (path != null && password != null) {
+        } else if (path != null) {

Review comment:
       cleanup of redundant logic




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org