You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/20 22:06:34 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #18432: [FLINK-25739][dist] Add Changelog to dist/opt
rkhachatryan opened a new pull request #18432:
URL: https://github.com/apache/flink/pull/18432
## What is the purpose of the change
Include Changelog jars into dist/opt.
## Verifying this change
This change is a trivial rework without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18432: [FLINK-25739][dist] Add Changelog to dist/opt
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147d0f216b23fbf00e8119ad05b3f5f77ec0d46f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Add Changelog to dist/opt
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147d0f216b23fbf00e8119ad05b3f5f77ec0d46f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a change in pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #18432:
URL: https://github.com/apache/flink/pull/18432#discussion_r790759862
##########
File path: flink-dist/pom.xml
##########
@@ -108,6 +108,18 @@ under the License.
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-statebackend-changelog</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-dstl-dfs</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review comment:
fixed in b14ababb8a5d1433710d69f2184b475c335dac2d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18432:
URL: https://github.com/apache/flink/pull/18432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18432:
URL: https://github.com/apache/flink/pull/18432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
}, {
"hash" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051",
"triggerID" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"triggerType" : "PUSH"
}, {
"hash" : "eed34f330aff2dae3d4ea3429cbec0fa83fa4a34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eed34f330aff2dae3d4ea3429cbec0fa83fa4a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48dbde106ac52703847f9150c3ffaf66c398ec77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899)
* b14ababb8a5d1433710d69f2184b475c335dac2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051)
* eed34f330aff2dae3d4ea3429cbec0fa83fa4a34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18432: [FLINK-25739][dist] Add Changelog to dist/opt
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1018262677
CI failure unrelated: https://issues.apache.org/jira/browse/FLINK-25740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
}, {
"hash" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051",
"triggerID" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"triggerType" : "PUSH"
}, {
"hash" : "eed34f330aff2dae3d4ea3429cbec0fa83fa4a34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30073",
"triggerID" : "eed34f330aff2dae3d4ea3429cbec0fa83fa4a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b14ababb8a5d1433710d69f2184b475c335dac2d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051)
* eed34f330aff2dae3d4ea3429cbec0fa83fa4a34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30073)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Add Changelog to dist/opt
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147d0f216b23fbf00e8119ad05b3f5f77ec0d46f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18432: [FLINK-25739][dist] Add Changelog to dist/opt
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18432:
URL: https://github.com/apache/flink/pull/18432#discussion_r789528450
##########
File path: flink-dist/src/main/assemblies/opt.xml
##########
@@ -118,13 +118,28 @@
<fileMode>0644</fileMode>
</file>
- <file>
+ <file>
<source>target/temporary/flink-shaded-zookeeper-3-${zookeeper.optional.version}-${flink.shaded.version}.jar</source>
<outputDirectory>opt</outputDirectory>
<destName>flink-shaded-zookeeper-${zookeeper.optional.version}.jar</destName>
<fileMode>0644</fileMode>
</file>
- </files>
+
+ <file>
+ <source>../flink-dstl/flink-dstl-dfs/target/flink-dstl-dfs-${project.version}.jar</source>
Review comment:
you should add dependencies to flink-dist for both of these modules to ensure they are built before flink-dist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
}, {
"hash" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051",
"triggerID" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48dbde106ac52703847f9150c3ffaf66c398ec77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899)
* b14ababb8a5d1433710d69f2184b475c335dac2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147d0f216b23fbf00e8119ad05b3f5f77ec0d46f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836)
* 48dbde106ac52703847f9150c3ffaf66c398ec77 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
}, {
"hash" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051",
"triggerID" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"triggerType" : "PUSH"
}, {
"hash" : "eed34f330aff2dae3d4ea3429cbec0fa83fa4a34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30073",
"triggerID" : "eed34f330aff2dae3d4ea3429cbec0fa83fa4a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48dbde106ac52703847f9150c3ffaf66c398ec77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899)
* b14ababb8a5d1433710d69f2184b475c335dac2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051)
* eed34f330aff2dae3d4ea3429cbec0fa83fa4a34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30073)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
}, {
"hash" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48dbde106ac52703847f9150c3ffaf66c398ec77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899)
* b14ababb8a5d1433710d69f2184b475c335dac2d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18432:
URL: https://github.com/apache/flink/pull/18432#discussion_r790640217
##########
File path: flink-dist/pom.xml
##########
@@ -108,6 +108,18 @@ under the License.
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-statebackend-changelog</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-dstl-dfs</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review comment:
inconsistent indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
}, {
"hash" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30051",
"triggerID" : "b14ababb8a5d1433710d69f2184b475c335dac2d",
"triggerType" : "PUSH"
}, {
"hash" : "eed34f330aff2dae3d4ea3429cbec0fa83fa4a34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30073",
"triggerID" : "eed34f330aff2dae3d4ea3429cbec0fa83fa4a34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eed34f330aff2dae3d4ea3429cbec0fa83fa4a34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30073)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18432: [FLINK-25739][dist] Add Changelog to dist/opt
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017971534
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 147d0f216b23fbf00e8119ad05b3f5f77ec0d46f (Thu Jan 20 22:11:06 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 147d0f216b23fbf00e8119ad05b3f5f77ec0d46f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836)
* 48dbde106ac52703847f9150c3ffaf66c398ec77 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1018626981
I've updated PR to include both jars into the Flink jar as agreed offline. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18432: [FLINK-25739][dist] Include Changelog to flink-dist jar
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18432:
URL: https://github.com/apache/flink/pull/18432#issuecomment-1017970404
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29836",
"triggerID" : "147d0f216b23fbf00e8119ad05b3f5f77ec0d46f",
"triggerType" : "PUSH"
}, {
"hash" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899",
"triggerID" : "48dbde106ac52703847f9150c3ffaf66c398ec77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 48dbde106ac52703847f9150c3ffaf66c398ec77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29899)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org