You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "luoyuxia (via GitHub)" <gi...@apache.org> on 2026/02/15 07:59:50 UTC
[PR] Introduce split & plan [paimon-rust]
luoyuxia opened a new pull request, #95:
URL: https://github.com/apache/paimon-rust/pull/95
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introduce split & plan [paimon-rust]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #95:
URL: https://github.com/apache/paimon-rust/pull/95#discussion_r2872390060
##########
crates/paimon/src/error.rs:
##########
@@ -34,6 +34,16 @@ pub enum Error {
display("Paimon hitting unsupported error {}", message)
)]
Unsupported { message: String },
+ #[snafu(
+ whatever,
+ display("Fluss hitting unexpected error {}: {:?}", message, source)
Review Comment:
Fluss -> Paimon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introduce split & plan [paimon-rust]
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #95:
URL: https://github.com/apache/paimon-rust/pull/95#issuecomment-3984353988
@XiaoHongbo-Hope Hi, comments are addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introduce split & plan [paimon-rust]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #95:
URL: https://github.com/apache/paimon-rust/pull/95#discussion_r2836141384
##########
crates/paimon/src/table/source.rs:
##########
@@ -0,0 +1,169 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Table source types: DataSplit, Plan, and related structs.
+//!
+//! Reference: [org.apache.paimon.table.source](https://github.com/apache/paimon/blob/master/paimon-core/src/main/java/org/apache/paimon/table/source/).
+
+#![allow(dead_code)]
+
+use crate::spec::{BinaryRow, DataFileMeta};
+
+// ======================= DataSplit ===============================
+
+/// Input split for reading: partition + bucket + list of data files.
+///
+/// Reference: [org.apache.paimon.table.source.DataSplit](https://github.com/apache/paimon/blob/master/paimon-core/src/main/java/org/apache/paimon/table/source/DataSplit.java)
+#[derive(Debug, Clone)]
+pub struct DataSplit {
+ snapshot_id: i64,
+ partition: BinaryRow,
+ bucket: i32,
+ bucket_path: String,
+ total_buckets: Option<i32>,
+ data_files: Vec<DataFileMeta>,
+}
+
+impl DataSplit {
+ pub fn snapshot_id(&self) -> i64 {
+ self.snapshot_id
+ }
+ pub fn partition(&self) -> &BinaryRow {
+ &self.partition
+ }
+ pub fn bucket(&self) -> i32 {
+ self.bucket
+ }
+ pub fn bucket_path(&self) -> &str {
+ &self.bucket_path
+ }
+ pub fn total_buckets(&self) -> Option<i32> {
+ self.total_buckets
+ }
+
+ pub fn data_files(&self) -> &[DataFileMeta] {
+ &self.data_files
+ }
+
+ /// Total row count of all data files in this split.
+ pub fn row_count(&self) -> i64 {
+ self.data_files.iter().map(|f| f.row_count).sum()
+ }
+
+ pub fn builder() -> DataSplitBuilder {
+ DataSplitBuilder::new()
+ }
+}
+
+/// Builder for [DataSplit].
+///
+/// Reference: [DataSplit.Builder](https://github.com/apache/paimon/blob/master/paimon-core/src/main/java/org/apache/paimon/table/source/DataSplit.java)
+#[derive(Debug)]
+pub struct DataSplitBuilder {
+ snapshot_id: i64,
+ partition: Option<BinaryRow>,
+ bucket: i32,
+ bucket_path: Option<String>,
+ total_buckets: Option<i32>,
+ data_files: Option<Vec<DataFileMeta>>,
+}
+
+impl DataSplitBuilder {
+ pub fn new() -> Self {
+ Self {
+ snapshot_id: 0,
+ partition: None,
+ bucket: -1,
+ bucket_path: None,
+ total_buckets: None,
+ data_files: None,
+ }
+ }
+
+ pub fn with_snapshot(mut self, snapshot_id: i64) -> Self {
+ self.snapshot_id = snapshot_id;
+ self
+ }
+ pub fn with_partition(mut self, partition: BinaryRow) -> Self {
+ self.partition = Some(partition);
+ self
+ }
+ pub fn with_bucket(mut self, bucket: i32) -> Self {
+ self.bucket = bucket;
+ self
+ }
+ pub fn with_bucket_path(mut self, bucket_path: String) -> Self {
+ self.bucket_path = Some(bucket_path);
+ self
+ }
+ pub fn with_total_buckets(mut self, total_buckets: Option<i32>) -> Self {
+ self.total_buckets = total_buckets;
+ self
+ }
+
+ pub fn build(self) -> crate::Result<DataSplit> {
+ let partition = self.partition.ok_or_else(|| crate::Error::ConfigInvalid {
+ message: "DataSplit requires partition".to_string(),
+ })?;
+ let bucket_path = self
+ .bucket_path
+ .ok_or_else(|| crate::Error::ConfigInvalid {
+ message: "DataSplit requires bucket_path".to_string(),
+ })?;
+ let data_files = self.data_files.ok_or_else(|| crate::Error::ConfigInvalid {
+ message: "DataSplit requires data_files".to_string(),
+ })?;
+ if self.bucket == -1 {
+ return Err(crate::Error::ConfigInvalid {
+ message: "DataSplit requires bucket != -1".to_string(),
+ });
+ }
+ Ok(DataSplit {
+ snapshot_id: self.snapshot_id,
+ partition,
+ bucket: self.bucket,
+ bucket_path,
+ total_buckets: self.total_buckets,
+ data_files,
+ })
+ }
+}
+
+impl Default for DataSplitBuilder {
+ fn default() -> Self {
+ Self::new()
+ }
+}
+
+// ======================= Plan ===============================
+
+/// Read plan: watermark, snapshot id, and list of splits.
Review Comment:
Comment mentions snapshot id, but the code does not have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introduce split & plan [paimon-rust]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on PR #95:
URL: https://github.com/apache/paimon-rust/pull/95#issuecomment-3984361328
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Introduce split & plan [paimon-rust]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #95:
URL: https://github.com/apache/paimon-rust/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org