[GitHub] [qpid-dispatch] gemmellr commented on a change in pull request #847: DISPATCH-1751: Rework how AMQP session incoming-window is derived

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #847:
URL: https://github.com/apache/qpid-dispatch/pull/847#discussion_r507874549



##########
File path: src/amqp.c
##########
@@ -96,6 +96,8 @@ const char * const QD_AMQPS_PORT_STR = "5671";
 
 const char * const QD_AMQP_DFLT_PROTO = "tcp";
 
+const int PN_AMQP_MAX_SESSION_CAPACITY_32BIT = 2147483647;

Review comment:
       Was it checked if this 2^31-1 value is actually the the limit? I commented before that prior discussion suggested it might not be though it needed verified:
   
   > Also though, if I'm remembering the last discussion of this, the value is unsigned and so wouldnt that make the configurable limit here 2^32 -1 instead really?
   
   Seperately, should it be PN_<foo> if its being defined by Dispatch? It may be about a Proton setting, but its still a Dispatch constant. Also nothing else here or in the include file seems to use anything except QD_




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org