You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by KurtYoung <gi...@git.apache.org> on 2017/02/21 06:51:23 UTC
[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/3372
[FLINK-5524] [table] Support early out for code generated AND/OR condition
For condition like a AND b, if the result of a is false, we can save b from execution.
For condition like a OR b, if the result of a is true, we can also save b from execution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/KurtYoung/flink flink-5524
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3372.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3372
----
commit 4f8c07ffc6ac99da67803114edb732e20df793e6
Author: Kurt Young <yk...@gmail.com>
Date: 2017-02-21T06:35:17Z
[FLINK-5524] [table] Support early out for code generated AND/OR conditions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...
Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3372#discussion_r102361046
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/CalcITCase.scala ---
@@ -217,6 +218,65 @@ class CalcITCase(
}
@Test
+ def testDisjunctivePredicateEarlyOut(): Unit = {
--- End diff --
Sure, thanks for the hint.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...
Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3372#discussion_r102421601
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/CalcITCase.scala ---
@@ -217,6 +217,21 @@ class CalcITCase(
}
@Test
+ def testConjunctivePredicate(): Unit = {
--- End diff --
ok, will do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3372
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3372#discussion_r102185303
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/CalcITCase.scala ---
@@ -217,6 +218,65 @@ class CalcITCase(
}
@Test
+ def testDisjunctivePredicateEarlyOut(): Unit = {
--- End diff --
Can you convert this test to a unit test with `ExpressionTestBase`? You can add them to `ScalarOperatorsTest`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3372: [FLINK-5524] [table] Support early out for code generated...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3372
Thanks for the update @KurtYoung. The code looks good. I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3372: [FLINK-5524] [table] Support early out for code ge...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3372#discussion_r102407744
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/CalcITCase.scala ---
@@ -217,6 +217,21 @@ class CalcITCase(
}
@Test
+ def testConjunctivePredicate(): Unit = {
--- End diff --
This is basically a pure code generation change, we really need no ITCase for that. Can you remove this one? We really should keep ITCases to a minimum. They add to much overhead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3372: [FLINK-5524] [table] Support early out for code generated...
Posted by KurtYoung <gi...@git.apache.org>.
Github user KurtYoung commented on the issue:
https://github.com/apache/flink/pull/3372
hey @twalthr, any more comments or this can be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---