[jira] [Commented] (NIFI-6666) InvokeHTTP should provide a User-agent header

["Joe Witt (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-6666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176653#comment-17176653 ] 

Joe Witt commented on NIFI-6666:
--------------------------------

[~mike.thomsen] This commit as-is could not be ok.  It blocks the source release to make NiFi 1.12 available.  After building the source release (which does not involve git) the build fails with 

[ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:4.0.0:revision (default) on project nifi-api: .git directory is not found! Please specify a valid [dotGitDirectory] in your pom.xml -> [Help 1]
[ERROR]

Adding support for setting a user agent header in InvokeHttp should not have any impact on the nifi-api at all.

> InvokeHTTP should provide a User-agent header
> ---------------------------------------------
>
>                 Key: NIFI-6666
>                 URL: https://issues.apache.org/jira/browse/NIFI-6666
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>            Priority: Major
>             Fix For: 1.12.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Currently the InvokeHTTP processor does not send out a User-agent header at all.
> It should provide such a header with an honest indication the request was done using Apache Nifi.
> I have created an implementation for this (pull request will follow shortly) that creates the following value automatically based on the Nifi version and the current system.
> *{{Apache Nifi/1.10.0-SNAPSHOT (git:rel/nifi-1.9.0-347-gec3ea46; Java/1.8.0_222; Linux 4.4.0-159-generic; amd64; https://nifi.apache.org/)}}*
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)