You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by su...@apache.org on 2024/02/21 06:42:11 UTC

(arrow-datafusion-comet) branch main updated: feat: Add `CometNativeException` for exceptions thrown from the native side (#62)

This is an automated email from the ASF dual-hosted git repository.

sunchao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion-comet.git


The following commit(s) were added to refs/heads/main by this push:
     new 8246739  feat: Add `CometNativeException` for exceptions thrown from the native side (#62)
8246739 is described below

commit 8246739a8dab0ae0b03bdc0d760c75c7c2de33c0
Author: Chao Sun <su...@apple.com>
AuthorDate: Tue Feb 20 22:42:05 2024 -0800

    feat: Add `CometNativeException` for exceptions thrown from the native side (#62)
---
 .../org/apache/comet/CometNativeException.java     | 27 ++++++++++++++++++++++
 core/src/errors.rs                                 |  2 +-
 2 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/common/src/main/java/org/apache/comet/CometNativeException.java b/common/src/main/java/org/apache/comet/CometNativeException.java
new file mode 100644
index 0000000..6251475
--- /dev/null
+++ b/common/src/main/java/org/apache/comet/CometNativeException.java
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.comet;
+
+/** Parent class for all exceptions thrown from Comet native side. */
+public class CometNativeException extends CometRuntimeException {
+  public CometNativeException(String message) {
+    super(message);
+  }
+}
diff --git a/core/src/errors.rs b/core/src/errors.rs
index 936d97d..0da2c9c 100644
--- a/core/src/errors.rs
+++ b/core/src/errors.rs
@@ -187,7 +187,7 @@ impl jni::errors::ToException for CometError {
                 msg: self.to_string(),
             },
             _other => Exception {
-                class: "org/apache/comet/CometRuntimeException".to_string(),
+                class: "org/apache/comet/CometNativeException".to_string(),
                 msg: self.to_string(),
             },
         }