You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Gert Vanthienen (JIRA)" <ji...@apache.org> on 2008/08/21 15:01:52 UTC
[jira] Created: (SM-1518) Aggregator keeps a list of closed
aggregations causing a slight memory leak
Aggregator keeps a list of closed aggregations causing a slight memory leak
---------------------------------------------------------------------------
Key: SM-1518
URL: https://issues.apache.org/activemq/browse/SM-1518
Project: ServiceMix
Issue Type: Improvement
Components: servicemix-eip
Affects Versions: 3.2.2
Reporter: Gert Vanthienen
Assignee: Gert Vanthienen
Priority: Minor
Fix For: 3.2.3, 3.3
As explained in the javadoc:
{code:java}
TODO: keep list of closed aggregations for a certain time
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1518) Aggregator keeps a list of closed
aggregations causing a slight memory leak
Posted by "Gert Vanthienen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gert Vanthienen resolved SM-1518.
---------------------------------
Resolution: Fixed
Refactored AbstractAggregator to use a Store instead of a simple Map to hold closed aggregations and added an in-memory Store implementation with timeout.
Added TimeoutMemoryStore to SMX 3 in http://svn.eu.apache.org/viewvc?view=rev&revision=687746 and fixed AbstractAggregator in http://svn.eu.apache.org/viewvc?view=rev&revision=687751
Fixed for branch in http://svn.eu.apache.org/viewvc?view=rev&revision=687735 and http://svn.eu.apache.org/viewvc?view=rev&revision=687740 (CheckStyle ;) )
> Aggregator keeps a list of closed aggregations causing a slight memory leak
> ---------------------------------------------------------------------------
>
> Key: SM-1518
> URL: https://issues.apache.org/activemq/browse/SM-1518
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-eip
> Affects Versions: 3.2.2
> Reporter: Gert Vanthienen
> Assignee: Gert Vanthienen
> Priority: Minor
> Fix For: 3.2.3, 3.3
>
>
> As explained in the javadoc:
> {code:java}
> TODO: keep list of closed aggregations for a certain time
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SM-1518) Aggregator keeps a list of closed
aggregations causing a slight memory leak
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved SM-1518.
---------------------------------
Resolution: Fixed
Sending src/main/java/org/apache/servicemix/eip/support/AbstractAggregator.java
Sending src/test/java/org/apache/servicemix/eip/SplitAggregatorTest.java
Transmitting file data ..
Committed revision 693002.
Sending servicemix-eip/src/main/java/org/apache/servicemix/eip/support/AbstractAggregator.java
Transmitting file data .
Committed revision 693003.
> Aggregator keeps a list of closed aggregations causing a slight memory leak
> ---------------------------------------------------------------------------
>
> Key: SM-1518
> URL: https://issues.apache.org/activemq/browse/SM-1518
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-eip
> Affects Versions: 3.2.2
> Reporter: Gert Vanthienen
> Assignee: Gert Vanthienen
> Priority: Minor
> Fix For: 3.2.3, 3.3
>
>
> As explained in the javadoc:
> {code:java}
> TODO: keep list of closed aggregations for a certain time
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SM-1518) Aggregator keeps a list of closed
aggregations causing a slight memory leak
Posted by "Ron Gavlin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ron Gavlin reopened SM-1518:
----------------------------
The fix for
http://fisheye6.atlassian.com/browse/servicemix/components/engines/servicemix-eip/trunk/src/main/java/org/apache/servicemix/eip/support/AbstractAggregator.java?r=687751#l302
introduced a regression. In the newly added code below, note that "store" should be replaced with "closedAggregates". Please fix ASAP.
I would also suggest that a "closed Aggregation" unit test be written to hopefully catch this type of regression in the future.
- Ron
- protected boolean isAggregationClosed(String correlationId) {
+ protected boolean isAggregationClosed(String correlationId) throws Exception {
// TODO: implement this using a persistent / cached behavior
- return closedAggregates.containsKey(correlationId);
+ Object data = store.load(correlationId);
+ if (data != null) {
+ store.store(correlationId, data);
+ }
+ return data != null;
}
> Aggregator keeps a list of closed aggregations causing a slight memory leak
> ---------------------------------------------------------------------------
>
> Key: SM-1518
> URL: https://issues.apache.org/activemq/browse/SM-1518
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-eip
> Affects Versions: 3.2.2
> Reporter: Gert Vanthienen
> Assignee: Gert Vanthienen
> Priority: Minor
> Fix For: 3.2.3, 3.3
>
>
> As explained in the javadoc:
> {code:java}
> TODO: keep list of closed aggregations for a certain time
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SM-1518) Aggregator keeps a list of closed
aggregations causing a slight memory leak
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/SM-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated SM-1518:
--------------------------------
Fix Version/s: servicemix-eip-2008.01
> Aggregator keeps a list of closed aggregations causing a slight memory leak
> ---------------------------------------------------------------------------
>
> Key: SM-1518
> URL: https://issues.apache.org/activemq/browse/SM-1518
> Project: ServiceMix
> Issue Type: Improvement
> Components: servicemix-eip
> Affects Versions: 3.2.2
> Reporter: Gert Vanthienen
> Assignee: Gert Vanthienen
> Priority: Minor
> Fix For: 3.2.3, 3.3, servicemix-eip-2008.01
>
>
> As explained in the javadoc:
> {code:java}
> TODO: keep list of closed aggregations for a certain time
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.