You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Andrew Cox (JIRA)" <ji...@apache.org> on 2012/05/25 20:44:24 UTC

[jira] [Created] (THRIFT-1612) Base64 encoding is broken

Andrew Cox created THRIFT-1612:
----------------------------------

             Summary: Base64 encoding is broken
                 Key: THRIFT-1612
                 URL: https://issues.apache.org/jira/browse/THRIFT-1612
             Project: Thrift
          Issue Type: Bug
          Components: C# - Library, C++ - Library, Java - Library, JavaME - Library
    Affects Versions: 0.8
         Environment: All
            Reporter: Andrew Cox
             Fix For: 0.9


Base64 encoding was broken. Looks like the same bug got copied from one language to the next.

The attached patch should fix it, and adds some tests as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (THRIFT-1612) Base64 encoding is broken

Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1612.
---------------------------------

    Resolution: Fixed

committed
                
> Base64 encoding is broken
> -------------------------
>
>                 Key: THRIFT-1612
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1612
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library, C++ - Library, Java - Library, JavaME - Library
>    Affects Versions: 0.8
>         Environment: All
>            Reporter: Andrew Cox
>             Fix For: 0.9
>
>         Attachments: 0001-Fix-base64-encoding.patch
>
>
> Base64 encoding was broken. Looks like the same bug got copied from one language to the next.
> The attached patch should fix it, and adds some tests as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1612) Base64 encoding is broken

Posted by "Andrew Cox (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Cox updated THRIFT-1612:
-------------------------------

    Attachment: 0001-Fix-base64-encoding.patch
    
> Base64 encoding is broken
> -------------------------
>
>                 Key: THRIFT-1612
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1612
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library, C++ - Library, Java - Library, JavaME - Library
>    Affects Versions: 0.8
>         Environment: All
>            Reporter: Andrew Cox
>             Fix For: 0.9
>
>         Attachments: 0001-Fix-base64-encoding.patch
>
>
> Base64 encoding was broken. Looks like the same bug got copied from one language to the next.
> The attached patch should fix it, and adds some tests as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1612) Base64 encoding is broken

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284202#comment-13284202 ] 

Hudson commented on THRIFT-1612:
--------------------------------

Integrated in Thrift #493 (See [https://builds.apache.org/job/Thrift/493/])
    THRIFT-1612 Base64 encoding is broken
Patch: Andrew Cox (Revision 1343074)

     Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1343074
Files : 
* /thrift/trunk/lib/cpp/src/thrift/protocol/TBase64Utils.cpp
* /thrift/trunk/lib/cpp/test/Base64Test.cpp
* /thrift/trunk/lib/cpp/test/Makefile.am
* /thrift/trunk/lib/csharp/src/Protocol/TBase64Utils.cs
* /thrift/trunk/lib/java/src/org/apache/thrift/protocol/TBase64Utils.java
* /thrift/trunk/lib/java/test/org/apache/thrift/protocol/ProtocolTestBase.java
* /thrift/trunk/lib/javame/src/org/apache/thrift/protocol/TBase64Utils.java

                
> Base64 encoding is broken
> -------------------------
>
>                 Key: THRIFT-1612
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1612
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Library, C++ - Library, Java - Library, JavaME - Library
>    Affects Versions: 0.8
>         Environment: All
>            Reporter: Andrew Cox
>             Fix For: 0.9
>
>         Attachments: 0001-Fix-base64-encoding.patch
>
>
> Base64 encoding was broken. Looks like the same bug got copied from one language to the next.
> The attached patch should fix it, and adds some tests as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira