You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nlpcraft.apache.org by "Sergey Kamov (Jira)" <ji...@apache.org> on 2021/01/24 08:36:00 UTC

[jira] [Resolved] (NLPCRAFT-226) Sql-gen-tool test should be created.

     [ https://issues.apache.org/jira/browse/NLPCRAFT-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergey Kamov resolved NLPCRAFT-226.
-----------------------------------
      Assignee: Aaron Radzinski  (was: Sergey Kamov)
    Resolution: Fixed

Note, please

1. It will works if SqlGenerator fixed, for the current version is failed (I have checked this test changing SqlGenerator locally)

2. About test location. I have added this test under the example folder, but it is used for test SqlGenerator, but not example. 
It was done because we need H2 SqlServer from examples package (module, in the further).

- We can keep it as is
 - We can move this test under sql generator folder and copy SqlServer logic to this test folder too.

What do you think?

> Sql-gen-tool test should be created.
> ------------------------------------
>
>                 Key: NLPCRAFT-226
>                 URL: https://issues.apache.org/jira/browse/NLPCRAFT-226
>             Project: NLPCraft
>          Issue Type: Improvement
>          Components: test
>            Reporter: Sergey Kamov
>            Assignee: Aaron Radzinski
>            Priority: Major
>             Fix For: 0.7.4
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)