You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/15 13:33:25 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Ouss4 opened a new pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544
## Summary
Changing a configuration from menuconfig and then recompiling wasn't affecting "head" files.
## Impact
Should recompile head files when configuration changes.
## Testing
esp32 board configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2544: arch/*/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-745293311
Looks OK. Did you verify that dep entries are added correctly to the Make.dep? You can also run with V=1 and see the mkdep calls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-745345783
Could you apply the change to other arch as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-745468348
Done. Please take a look.
Can you or @xiaoxiang781216 double check that this is not needed for the simulator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-745289813
Other arch/ also need something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-745389736
Ok, I'm converting to draft in the meantime just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-745360475
> Could you apply the change to other arch as well?
Yes, will do that in a moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-745294758
> Looks OK. Did you verify that dep entries are added correctly to the Make.dep? You can also run with V=1 and see the mkdep calls.
Yes, actually I looked there first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SYKAP commented on pull request #2544: arch/*/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
SYKAP commented on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-747158644
@Ouss4 would u like to contact me?Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #2544: arch/xtensa/src/Makefile: Generate dependencies for "head" files.
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #2544:
URL: https://github.com/apache/incubator-nuttx/pull/2544#issuecomment-745289813
Other archs/ also need something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org