You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smitajoshi12 (via GitHub)" <gi...@apache.org> on 2023/10/27 10:58:50 UTC

[PR] Recon UI : Bucket Drop down filter is not getting disabled when more than 1 volume is selected [ozone]

smitajoshi12 opened a new pull request, #5503:
URL: https://github.com/apache/ozone/pull/5503

   #What changes were proposed in this pull request?
   [Recon][UI] On File Size Insights Page
   Bucket Drop down filter is not getting disabled when more than 1 volume is selected
   As discussed, bucket drop down filter works only for 1 volume and can't be used if more than 1 volume are present.
   When 2 volumes are selected the Bucket list drop down is not getting disabled, whereas on selecting 3 volumes it is getting disabled.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-9556
   
   ## How was this patch tested?
   Manually
   After this PR change
   ![image](https://github.com/apache/ozone/assets/112169209/648c07e4-63a3-41f8-abaa-b3f4a2659abb)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] Recon UI : Bucket Drop down filter is not getting disabled when more than 1 volume is selected [ozone]

Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #5503:
URL: https://github.com/apache/ozone/pull/5503#discussion_r1374438716


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/insights.tsx:
##########
@@ -95,7 +95,7 @@ export class Insights extends React.Component<Record<string, object>, IInsightsS
     // If there is only one volume, bucket selection dropdown should not be disabled.
     const isBucketSelectionDisabled = !selectedVolumes ||
         (selectedVolumes &&
-            (selectedVolumes.length > 2 &&
+            (selectedVolumes.length >= 2 &&

Review Comment:
   @smitajoshi12 thanks for the patch, however this could be more readable for any developer to easily understand if you could use the condition >1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-9556. Recon UI : Bucket Drop down filter is not getting disabled when more than 1 volume is selected [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita merged PR #5503:
URL: https://github.com/apache/ozone/pull/5503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-9556. Recon UI : Bucket Drop down filter is not getting disabled when more than 1 volume is selected [ozone]

Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5503:
URL: https://github.com/apache/ozone/pull/5503#discussion_r1374452142


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/insights.tsx:
##########
@@ -95,7 +95,7 @@ export class Insights extends React.Component<Record<string, object>, IInsightsS
     // If there is only one volume, bucket selection dropdown should not be disabled.
     const isBucketSelectionDisabled = !selectedVolumes ||
         (selectedVolumes &&
-            (selectedVolumes.length > 2 &&
+            (selectedVolumes.length >= 2 &&

Review Comment:
   @devmadhuu 
   Hi Devesh Done changes in recent commit as per suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-9556. Recon UI : Bucket Drop down filter is not getting disabled when more than 1 volume is selected [ozone]

Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5503:
URL: https://github.com/apache/ozone/pull/5503#issuecomment-1785415565

   Thanks for working on this @smitajoshi12, thanks @devmadhuu for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org