You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Felix Knecht (JIRA)" <se...@james.apache.org> on 2011/04/04 11:23:06 UTC

[jira] [Commented] (JAMES-711) Reformat James sources to remove bad style

    [ https://issues.apache.org/jira/browse/JAMES-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015327#comment-13015327 ] 

Felix Knecht commented on JAMES-711:
------------------------------------

I'll do the reformatting using the defaults given by Eclipse and applying following additional rules for java and javascript files:

https://svn.apache.org/repos/asf/james/project/trunk/project/src/site/resources/downloads/formatting.xml
https://svn.apache.org/repos/asf/james/project/trunk/project/src/site/resources/downloads/codetemplates.xml

Please be aware, that almost every *.java file will be touched/changed by this.

> Reformat James sources to remove bad style
> ------------------------------------------
>
>                 Key: JAMES-711
>                 URL: https://issues.apache.org/jira/browse/JAMES-711
>             Project: JAMES Server
>          Issue Type: Task
>    Affects Versions: 3.0
>            Reporter: Stefano Bagnara
>            Assignee: Felix Knecht
>            Priority: Trivial
>             Fix For: 3.0-M3
>
>
> We have a lot of code that does not follow the coding style we're using
> Moslty bad number of spaces and open brackets in the newline instead of the end of the previous line.
> At least in the whole IMAP code and other "active" code we should run a reformat to keep "style" consistent.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: [jira] [Commented] (JAMES-711) Reformat James sources to remove bad style

Posted by Norman Maurer <no...@apache.org>.
+1..

Just doing it now before the next release sounds like a very good idea :)

Bye,
Norman


2011/4/4 Felix Knecht (JIRA) <se...@james.apache.org>

>
>    [
> https://issues.apache.org/jira/browse/JAMES-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015327#comment-13015327]
>
> Felix Knecht commented on JAMES-711:
> ------------------------------------
>
> I'll do the reformatting using the defaults given by Eclipse and applying
> following additional rules for java and javascript files:
>
>
> https://svn.apache.org/repos/asf/james/project/trunk/project/src/site/resources/downloads/formatting.xml
>
> https://svn.apache.org/repos/asf/james/project/trunk/project/src/site/resources/downloads/codetemplates.xml
>
> Please be aware, that almost every *.java file will be touched/changed by
> this.
>
> > Reformat James sources to remove bad style
> > ------------------------------------------
> >
> >                 Key: JAMES-711
> >                 URL: https://issues.apache.org/jira/browse/JAMES-711
> >             Project: JAMES Server
> >          Issue Type: Task
> >    Affects Versions: 3.0
> >            Reporter: Stefano Bagnara
> >            Assignee: Felix Knecht
> >            Priority: Trivial
> >             Fix For: 3.0-M3
> >
> >
> > We have a lot of code that does not follow the coding style we're using
> > Moslty bad number of spaces and open brackets in the newline instead of
> the end of the previous line.
> > At least in the whole IMAP code and other "active" code we should run a
> reformat to keep "style" consistent.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
>
>