You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/25 04:30:08 UTC
[GitHub] [arrow-datafusion] Ted-Jiang opened a new pull request, #2612: [MINOR] remove datafusion-cli's ballista feature
Ted-Jiang opened a new pull request, #2612:
URL: https://github.com/apache/arrow-datafusion/pull/2612
# Which issue does this PR close?
Now we not support connect ballista using datafusion-cli
```
datafusion-cli % cargo build --features ballista
error: none of the selected packages contains these features: ballista
```
It moved to https://github.com/apache/arrow-ballista/tree/master/ballista-cli
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
# Does this PR break compatibility with Ballista?
<!--
The CI checks will attempt to build [arrow-ballista](https://github.com/apache/arrow-ballista) against this PR. If
this check fails then it indicates that this PR makes a breaking change to the DataFusion API.
If possible, try to make the change in a way that is not a breaking API change. For example, if code has moved
around, try adding `pub use` from the original location to preserve the current API.
If it is not possible to avoid a breaking change (such as when adding enum variants) then follow this process:
- Make a corresponding PR against `arrow-ballista` with the changes required there
- Update `dev/build-arrow-ballista.sh` to clone the appropriate `arrow-ballista` repo & branch
- Merge this PR when CI passes
- Merge the Ballista PR
- Create a new PR here to reset `dev/build-arrow-ballista.sh` to point to `arrow-ballista` master again
_If you would like to help improve this process, please see https://github.com/apache/arrow-datafusion/issues/2583_
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #2612: [MINOR] remove datafusion-cli's ballista feature
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2612:
URL: https://github.com/apache/arrow-datafusion/pull/2612#discussion_r881405054
##########
docs/source/user-guide/cli.md:
##########
@@ -19,8 +19,7 @@
# DataFusion Command-line Interface
-The DataFusion CLI allows SQL queries to be executed by an in-process DataFusion context, or by a distributed
-Ballista context.
+The DataFusion CLI allows SQL queries to be executed by an in-process DataFusion context.
```
USAGE:
Review Comment:
i think it still need diff between `FLAGS ` and `OPTIONS `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2612: [MINOR] remove datafusion-cli's ballista feature from docs
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2612:
URL: https://github.com/apache/arrow-datafusion/pull/2612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] waynexia commented on a diff in pull request #2612: [MINOR] remove datafusion-cli's ballista feature
Posted by GitBox <gi...@apache.org>.
waynexia commented on code in PR #2612:
URL: https://github.com/apache/arrow-datafusion/pull/2612#discussion_r881260305
##########
docs/source/user-guide/cli.md:
##########
@@ -19,8 +19,7 @@
# DataFusion Command-line Interface
-The DataFusion CLI allows SQL queries to be executed by an in-process DataFusion context, or by a distributed
-Ballista context.
+The DataFusion CLI allows SQL queries to be executed by an in-process DataFusion context.
```
USAGE:
Review Comment:
According to https://github.com/apache/arrow-datafusion/pull/2604/ I think this entire block needs to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] waynexia commented on a diff in pull request #2612: [MINOR] remove datafusion-cli's ballista feature
Posted by GitBox <gi...@apache.org>.
waynexia commented on code in PR #2612:
URL: https://github.com/apache/arrow-datafusion/pull/2612#discussion_r881469007
##########
docs/source/user-guide/cli.md:
##########
@@ -19,8 +19,7 @@
# DataFusion Command-line Interface
-The DataFusion CLI allows SQL queries to be executed by an in-process DataFusion context, or by a distributed
-Ballista context.
+The DataFusion CLI allows SQL queries to be executed by an in-process DataFusion context.
```
USAGE:
Review Comment:
I agree with you. But this seems to be a "feature" of the code (or clap) 🤔 It looks like that at some point clap changed its behavior, doesn't distinguish FLAG and OPTION.
And for the document here I think this block is intended to be a place to show the help text, and that's what I get by `cargo run -- --help`:
```
datafusion-cli 8.0.0
Apache Arrow <de...@arrow.apache.org>
Command Line Client for DataFusion query engine.
USAGE:
datafusion-cli [OPTIONS]
OPTIONS:
-c, --batch-size <BATCH_SIZE> The batch size of each query, or use DataFusion default
-f, --file <FILE>... Execute commands from file(s), then exit
--format <FORMAT> [default: table] [possible values: csv, tsv, table, json,
nd-json]
-h, --help Print help information
-p, --data-path <DATA_PATH> Path to your data, default to current directory
-q, --quiet Reduce printing other than the results and work quietly
-r, --rc <RC>... Run the provided files on startup instead of ~/.datafusionrc
-V, --version Print version information
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on pull request #2612: [MINOR] remove datafusion-cli's ballista feature from docs
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on PR #2612:
URL: https://github.com/apache/arrow-datafusion/pull/2612#issuecomment-1138241111
@Ted-Jiang
From this page https://github.com/apache/arrow-ballista/tree/master/ballista-cli, the document is not fit for the current project, could you please update the doc in the ballista project.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org