You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kf...@apache.org on 2018/07/30 09:21:41 UTC

svn commit: r1837033 - in /tomcat/trunk/java/org/apache/catalina/tribes/membership: LocalStrings.properties StaticMembershipProvider.java

Author: kfujino
Date: Mon Jul 30 09:21:41 2018
New Revision: 1837033

URL: http://svn.apache.org/viewvc?rev=1837033&view=rev
Log:
Implement MemberMessage.getTypeDesc().
Add log messagess.

Modified:
    tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties
    tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java

Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties?rev=1837033&r1=1837032&r2=1837033&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties Mon Jul 30 09:21:41 2018
@@ -51,4 +51,6 @@ memberImpl.unableParse.hostname=Unable t
 memberImpl.large.payload=Payload is to large for tribes to handle.
 staticMember.invalid.uuidLength=UUID must be exactly 16 bytes, not:[{0}]
 staticMembershipService.stopFail=Unable to stop the static membership service, level: [{0}]
-staticMembershipProvider.pingThread.failed=Unable to send ping.
\ No newline at end of file
+staticMembershipProvider.pingThread.failed=Unable to send ping.
+staticMembershipProvider.replyRequest.ignored=Message[{0}] is ignored.
+staticMembershipProvider.leftOver.ignored=Message[{0}] is ignored.
\ No newline at end of file

Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java?rev=1837033&r1=1837032&r2=1837033&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java Mon Jul 30 09:21:41 2018
@@ -219,7 +219,8 @@ public class StaticMembershipProvider ex
         } else {
             // other messages are ignored.
             if (log.isInfoEnabled())
-                log.info("never happen");
+                log.info(sm.getString("staticMembershipProvider.replyRequest.ignored",
+                        memMsg.getTypeDesc()));
             return null;
         }
     }
@@ -235,7 +236,8 @@ public class StaticMembershipProvider ex
         } else {
             // other messages are ignored.
             if (log.isInfoEnabled())
-                log.info("never happen");
+                log.info(sm.getString("staticMembershipProvider.leftOver.ignored",
+                        memMsg.getTypeDesc()));
         }
     }
 
@@ -342,6 +344,19 @@ public class StaticMembershipProvider ex
         public String toString() {
             return super.toString();
         }
+
+        protected String getTypeDesc() {
+            switch (msgtype) {
+            case MSG_START:
+                return "MSG_START";
+            case MSG_STOP:
+                return "MSG_STOP";
+            case MSG_PING:
+                return "MSG_PING";
+            default:
+                return "UNKNOWN";
+            }
+        }
     }
 
     protected class PingThread extends Thread {



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org