You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/25 21:48:54 UTC

[GitHub] [airflow] suburbanmtman opened a new pull request #6185: [AIRFLOW-5554] Require statsd 3.3.0 for timedelta stat transformation

suburbanmtman opened a new pull request #6185: [AIRFLOW-5554] Require statsd 3.3.0 for timedelta stat transformation
URL: https://github.com/apache/airflow/pull/6185
 
 
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ X ] My PR addresses the following [Airflow Jira]
     - https://issues.apache.org/jira/browse/AIRFLOW-5554
   
   ### Description
   
   - [ X ] Here are some details about my PR, including screenshots of any UI changes:
   When statsd is enabled in airflow, there are some calls to the statsd client library that pass timedeltas as the duration for measuring the timing, including dag success and failure durations.
   
   However, handling timedeltas and converting them to millisecond floats is not introduced until statsd 3.3.0. This should be the minimum version required in airflow to avoid a TypeError in these stats.
   
   ### Tests
   
   - [ X ] My PR does not need testing for this extremely good reason:
   No code changes introduced, the only behavioral change is inside the statsd library implementation due to the version change.
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ X ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services