You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/28 19:42:35 UTC
[GitHub] [superset] Antonio-RiveroMartnez opened a new pull request, #21628: fix(sqllab): SqlEditorLeftBar listening to database changes
Antonio-RiveroMartnez opened a new pull request, #21628:
URL: https://github.com/apache/superset/pull/21628
### SUMMARY
We stopped listening to database prop changes at some point to only take into account the initial component render. That however, caused the component to always work with the initial database passed as prop and never take into account new user selections. Which you might evidence for example with empty table dropdown after changing DB.
We're bringing that feature back with this fix. Also we're using the right props in our tests and adding a new one to consider the re-renders with new database.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TESTING INSTRUCTIONS
Go to sql lab and do a query on your default data base
In the same query tab, switch databases
Select your table
Try to select a table
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #21628: fix(sqllab): SqlEditorLeftBar listening to database changes
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on PR #21628:
URL: https://github.com/apache/superset/pull/21628#issuecomment-1265792640
🏷️ preset:2022.39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #21628: fix(sqllab): SqlEditorLeftBar listening to database changes
Posted by GitBox <gi...@apache.org>.
hughhhh merged PR #21628:
URL: https://github.com/apache/superset/pull/21628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org