[GitHub] [druid] LakshSingla commented on a diff in pull request #14257: Configure maxBytesPerWorker directly instead of using StageDefinition

["LakshSingla (via GitHub)" <gi...@apache.org>]

LakshSingla commented on code in PR #14257:
URL: https://github.com/apache/druid/pull/14257#discussion_r1191477847


##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestControllerContext.java:
##########
@@ -66,7 +66,8 @@ public class MSQTestControllerContext implements ControllerContext
   private final TaskActionClient taskActionClient;
   private final Map<String, Worker> inMemoryWorkers = new HashMap<>();
   private final ConcurrentMap<String, TaskStatus> statusMap = new ConcurrentHashMap<>();
-  private final ListeningExecutorService executor = MoreExecutors.listeningDecorator(Execs.singleThreaded(
+  private final ListeningExecutorService executor = MoreExecutors.listeningDecorator(Execs.multiThreaded(

Review Comment:
   Can you create this 4 a final constant which signifies what it means (Number of workers I presume). 



##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/kernel/WorkerAssignmentStrategy.java:
##########
@@ -67,15 +68,16 @@ public List<InputSlice> assign(
         final StageDefinition stageDef,
         final InputSpec inputSpec,
         final Int2IntMap stageWorkerCountMap,
-        final InputSpecSlicer slicer
+        final InputSpecSlicer slicer,
+        final long maxInputBytesPerWorker

Review Comment:
   The variable name here should change because in the assignment strategy, there is no concept of the worker. 
   Also, can you create a Javadoc for assign where we mention what each parameter means. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org