You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2026/05/10 11:24:19 UTC

svn commit: r1934044 - in pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger: . pagepane

Author: tilman
Date: Sun May 10 11:24:19 2026
New Revision: 1934044

Log:
PDFBOX-5660: refactor, avoid leaking this in constructor

Modified:
   pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
   pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/pagepane/PagePane.java

Modified: pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
==============================================================================
--- pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java	Sun May 10 11:10:04 2026	(r1934043)
+++ pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java	Sun May 10 11:24:19 2026	(r1934044)
@@ -1063,6 +1063,7 @@ public class PDFDebugger extends JFrame
             if (COSName.PAGE.equals(typeItem))
             {
                 PagePane pagePane = new PagePane(document, page, statusBar.getStatusLabel());
+                pagePane.init();
                 replaceRightComponent(new JScrollPane(pagePane.getPanel()));
             }
         }

Modified: pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/pagepane/PagePane.java
==============================================================================
--- pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/pagepane/PagePane.java	Sun May 10 11:10:04 2026	(r1934043)
+++ pdfbox/branches/3.0/debugger/src/main/java/org/apache/pdfbox/debugger/pagepane/PagePane.java	Sun May 10 11:24:19 2026	(r1934044)
@@ -119,6 +119,13 @@ public class PagePane implements ActionL
         pageIndex = document.getPages().indexOf(page);
         this.document = document;
         this.statuslabel = statuslabel;
+    }
+
+    /**
+     * Initialization, to be called immediately after construction.
+     */
+    public void init()
+    {
         initUI();
         initRectMap();
     }