You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "nicusX (via GitHub)" <gi...@apache.org> on 2024/11/13 09:31:21 UTC

[PR] [FLINK-36595][docs] Fix docs data file [flink-connector-mongodb]

nicusX opened a new pull request, #46:
URL: https://github.com/apache/flink-connector-mongodb/pull/46

   Fix docs data file for v1.2
   
   ### Purpose of the change
   
   * Update stable connector version to latest 1.2.0
   * Set version as string to prevent version comparison mismatch. Issue has happened for other connectors too https://github.com/apache/flink-connector-kafka/pull/132
   
   ### Significant changes
   
   No significant changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36595][docs] Fix docs data file [flink-connector-mongodb]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #46:
URL: https://github.com/apache/flink-connector-mongodb/pull/46#discussion_r2556396075


##########
docs/data/mongodb.yml:
##########
@@ -16,8 +16,8 @@
 # limitations under the License.
 ################################################################################
 
-version: 1.1.2
-flink_compatibility: [1.18, 1.19]
+version: 1.2.0
+flink_compatibility: ["1.18", "1.19"]

Review Comment:
   this i quite old now - I assume you want to add in Flink 1.20.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36595][docs] Fix docs data file [flink-connector-mongodb]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky merged PR #46:
URL: https://github.com/apache/flink-connector-mongodb/pull/46


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36595][docs] Fix docs data file [flink-connector-mongodb]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #46:
URL: https://github.com/apache/flink-connector-mongodb/pull/46#issuecomment-2472976468

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-36595][docs] Fix docs data file [flink-connector-mongodb]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #46:
URL: https://github.com/apache/flink-connector-mongodb/pull/46#issuecomment-3999613910

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org