You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/07 01:37:55 UTC
[GitHub] [fineract-cn-data-jpa] xurror opened a new pull request #10: Spring boot 2
xurror opened a new pull request #10:
URL: https://github.com/apache/fineract-cn-data-jpa/pull/10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-data-jpa] xurror commented on a change in pull request #10: Spring boot 2
Posted by GitBox <gi...@apache.org>.
xurror commented on a change in pull request #10:
URL: https://github.com/apache/fineract-cn-data-jpa/pull/10#discussion_r422031914
##########
File path: src/main/java/org/apache/fineract/cn/core/data/jpa/DataJpaApplication.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.cn.core.data.jpa;
+
+import org.springframework.boot.SpringApplication;
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
+@SpringBootApplication
+public class DataJpaApplication {
+
+ public static void main(String[] args) {
+ SpringApplication.run(DataJpaApplication.class, args);
Review comment:
Oh, sorry for that. It was autogenerated while I was running tests locally. Skipped my attention.
It should be OK now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-data-jpa] xurror commented on pull request #10: Spring boot 2
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #10:
URL: https://github.com/apache/fineract-cn-data-jpa/pull/10#issuecomment-624987019
@aasaru
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract-cn-data-jpa] aasaru commented on a change in pull request #10: Spring boot 2
Posted by GitBox <gi...@apache.org>.
aasaru commented on a change in pull request #10:
URL: https://github.com/apache/fineract-cn-data-jpa/pull/10#discussion_r421970414
##########
File path: src/main/java/org/apache/fineract/cn/core/data/jpa/DataJpaApplication.java
##########
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.cn.core.data.jpa;
+
+import org.springframework.boot.SpringApplication;
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
+@SpringBootApplication
+public class DataJpaApplication {
+
+ public static void main(String[] args) {
+ SpringApplication.run(DataJpaApplication.class, args);
Review comment:
Are you sure this library can be run as Spring Boot application?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org