[jira] [Commented] (SOLR-8305) can LatLonType.getValueSource's QParser use be replaced?

["David Smiley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050123#comment-15050123 ] 

David Smiley commented on SOLR-8305:
------------------------------------

+1 to the patch

+0 to also eventually removing QParser from getValueSource's signature (separate issue).  I've found it useful for doing interesting/custom things from the getValueSource method since it provides context to the outside world beyond simply fetching the valueSource.  However I believe the cases where I've used it, I could have used the SolrRequestInfo ThreadLocal/singleton.

> can LatLonType.getValueSource's QParser use be replaced?
> --------------------------------------------------------
>
>                 Key: SOLR-8305
>                 URL: https://issues.apache.org/jira/browse/SOLR-8305
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-8305.patch, SOLR-8305.patch
>
>
> Question with patch against trunk. Context is that elsewhere in the classes the {{IndexSchema}} member is used instead of the {{QParser}} method parameter and would the resulting schema not be the same when using the member instead of the parameter? Motivation here is potential removal of the QParser argument from the {{getValueSource}} signature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org