You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "qidian99 (via GitHub)" <gi...@apache.org> on 2023/05/22 02:30:12 UTC

[GitHub] [incubator-paimon] qidian99 opened a new issue, #1188: [Bug] ConfigOptionsDocsCompletenessITCase::testCompleteness failed when CoreOption changed

qidian99 opened a new issue, #1188:
URL: https://github.com/apache/incubator-paimon/issues/1188

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/incubator-paimon/issues) and found nothing similar.
   
   
   ### Paimon version
   
   0.5-SNAPSHOT
   
   ### Compute Engine
   
   Flink
   
   ### Minimal reproduce step
   
   1. Change core option and run `mvn package -Pgenerate-docs -pl paimon-docs -nsu -DskipTests` as described in `paimon-docs/README.md` 
   
   2. Run the test ConfigOptionsDocsCompletenessITCase::testCompleteness 
   
   ### What doesn't meet your expectations?
   
   Test failed.
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on issue #1188: [Bug] ConfigOptionsDocsCompletenessITCase::testCompleteness failed when CoreOption changed

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #1188:
URL: https://github.com/apache/incubator-paimon/issues/1188#issuecomment-1556692802

   1. Modify CoreOptions.
   2. mvn clean install -DskipTests
   3. mvn package -Pgenerate-docs -pl paimon-docs -nsu -DskipTests
   
   All works fine now.
   What is the problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on issue #1188: [Bug] ConfigOptionsDocsCompletenessITCase::testCompleteness failed when CoreOption changed

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on issue #1188:
URL: https://github.com/apache/incubator-paimon/issues/1188#issuecomment-1556479766

   Can you describe the detailed reproduce step? I cannot fully understand this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Bug] ConfigOptionsDocsCompletenessITCase::testCompleteness failed when CoreOption changed [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed issue #1188: [Bug] ConfigOptionsDocsCompletenessITCase::testCompleteness failed when CoreOption changed
URL: https://github.com/apache/paimon/issues/1188


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] qidian99 commented on issue #1188: [Bug] ConfigOptionsDocsCompletenessITCase::testCompleteness failed when CoreOption changed

Posted by "qidian99 (via GitHub)" <gi...@apache.org>.
qidian99 commented on issue #1188:
URL: https://github.com/apache/incubator-paimon/issues/1188#issuecomment-1556642582

   After I changed some CoreOptions, and tried to rebuild the docs, it is not updating the generated docs.
   
   However, when I run ConfigOptionsDocGenerator directly by passing 2 args (doc path and project root), the generated doc contains my change.
   
   Therefore, I further debugged the paimon-docs module and found out the ${rootDir} variable is not well respected (at least for my maven version 3.6.3). After adding the rootDir property to `../`, the docs are correctly genearted.
   
   @JingsongLi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org