You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "saikethan27 (via GitHub)" <gi...@apache.org> on 2023/09/27 15:06:00 UTC
[GitHub] [beam] saikethan27 opened a new pull request, #28680: Update core.py [If funnction do not return any thing then warning will be pop up]
saikethan27 opened a new pull request, #28680:
URL: https://github.com/apache/beam/pull/28680
If `self.fn.process` does not return anything [`None`] then `warning ` will be popped as
```
_LOGGER.warning(
no iterator is returned by the process method in DoFn)
```
where changes are committed in function `_check_fn_use_yield_and_return` to check if yield or return any one is present in code
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28680: Update core.py [If funnction do not return any thing then warning will be pop up]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28680:
URL: https://github.com/apache/beam/pull/28680#issuecomment-1737927487
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28680: Update core.py [If funnction do not return any thing then warning will be pop up]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28680:
URL: https://github.com/apache/beam/pull/28680#issuecomment-1737735584
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] saikethan27 commented on pull request #28680: Update core.py [If funnction do not return any thing then warning will be pop up]
Posted by "saikethan27 (via GitHub)" <gi...@apache.org>.
saikethan27 commented on PR #28680:
URL: https://github.com/apache/beam/pull/28680#issuecomment-1737875844
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #28680: Update core.py [If funnction do not return any thing then warning will be pop up]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28680:
URL: https://github.com/apache/beam/pull/28680#issuecomment-1737624648
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#28680](https://app.codecov.io/gh/apache/beam/pull/28680?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (95833a6) into [master](https://app.codecov.io/gh/apache/beam/commit/7d78572baa21fcd5b235371161e1181168284a02?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7d78572) will **increase** coverage by `0.00%`.
> Report is 3 commits behind head on master.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #28680 +/- ##
=======================================
Coverage 71.96% 71.97%
=======================================
Files 680 680
Lines 100163 100171 +8
=======================================
+ Hits 72087 72094 +7
- Misses 26498 26499 +1
Partials 1578 1578
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/28680/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/28680/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.54% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/beam/pull/28680?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/transforms/core.py](https://app.codecov.io/gh/apache/beam/pull/28680?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb3JlLnB5) | `91.49% <100.00%> (+0.04%)` | :arrow_up: |
... and [4 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28680/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a diff in pull request #28680: Update core.py [If funnction do not return any thing then warning will be pop up]
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on code in PR #28680:
URL: https://github.com/apache/beam/pull/28680#discussion_r1339140947
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -1484,8 +1490,13 @@ def __init__(self, fn, *args, **kwargs):
'Using yield and return in the process method '
'of %s can lead to unexpected behavior, see:'
'https://github.com/apache/beam/issues/22969.',
- self.fn.__class__)
+ self.fn.__class__)
+ elif _check_fn_use_yield_and_return(self.fn.process) is None:
+ _LOGGER.warning(
+ 'no iterator is returned by the process method in %s',
+ self.fn.__class__)
+
Review Comment:
Mechanically you probably don't want to re-run `_check_fn_use_yield_and_return()` here. Consider capturing the output value the first time and using that here instead
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -1423,15 +1423,21 @@ def _check_fn_use_yield_and_return(fn):
source_code = _get_function_body_without_inners(fn)
has_yield = False
has_return = False
+ if len(source_code)==0:
+ return None
Review Comment:
What is the purpose of this check?
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -1423,15 +1423,21 @@ def _check_fn_use_yield_and_return(fn):
source_code = _get_function_body_without_inners(fn)
has_yield = False
has_return = False
+ if len(source_code)==0:
+ return None
for line in source_code.split("\n"):
if line.lstrip().startswith("yield ") or line.lstrip().startswith(
"yield("):
has_yield = True
if line.lstrip().startswith("return ") or line.lstrip().startswith(
"return("):
has_return = True
+ if line.lstrip().startswith("return None"):
Review Comment:
The warn could also be placed here instead, eliminating the need for the `elif` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update core.py [If funnction do not return any thing then warning will be pop up] [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #28680:
URL: https://github.com/apache/beam/pull/28680#issuecomment-1783053908
I think this is trying to do the same thing as https://github.com/apache/beam/pull/28159 which was opened first and seems slightly more complete, so I think we should proceed with that one and I'm going to close this pull request.
In general, please make sure that you are assigned to an issue before you start working on it to avoid duplicate work. If someone else is assigned but you're not sure if they're working on the problem, its usually best to ask first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update core.py [If funnction do not return any thing then warning will be pop up] [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #28680: Update core.py [If funnction do not return any thing then warning will be pop up]
URL: https://github.com/apache/beam/pull/28680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org