You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Mridul Pathak (Jira)" <ji...@apache.org> on 2026/09/15 06:56:00 UTC

[jira] [Created] (OFBIZ-13593) Four regressions in PartyServicesScript.groovy: crash, dropped field, and permission-adjacent divergences

Mridul Pathak created OFBIZ-13593:
-------------------------------------

             Summary: Four regressions in PartyServicesScript.groovy: crash, dropped field, and permission-adjacent divergences
                 Key: OFBIZ-13593
                 URL: https://issues.apache.org/jira/browse/OFBIZ-13593
             Project: OFBiz
          Issue Type: Bug
          Components: party
    Affects Versions: 24.09.07, Upcoming Branch
            Reporter: Mridul Pathak
            Assignee: Mridul Pathak


Four issues in {{PartyServicesScript.groovy}}:

# {{followPartyRelationshipsInlineRecurse}}: in the {{includeFromToSwitched == 'Y'}} branch, reads a nonexistent {{partyRel.partyFrom}} field (should be {{partyIdFrom}}), throwing {{IllegalArgumentException}}. Reachable via {{getParentOrganizations}}, itself called from {{GPeriodServices.findCustomTimePeriods}} — any organization party with a {{GROUP_ROLLUP}} parent relationship crashes this.
# {{getChildRoleTypes}}: an unfixed remnant of the earlier finding #14 fix — that fix patched two call sites of {{getChildRoleTypesInline}} to re-prepend the seed role type, but missed this third caller, which still silently excludes the seed role type from its result.
# {{getPartiesByRelationship}}: uses {{lookupMap.setAllFields(parameters, false, null, null)}}, which includes any of several fields (fromDate, thruDate, relationshipName, etc.) the original minilang deliberately excluded from its search map even though they're valid declared attributes — a caller supplying one of these gets a narrower/different result set than minilang would.
# {{getPartyNameForDate}}: when a historical name change exists, {{gender}} is silently dropped from the result (gated behind a condition that's always false in that case) since {{PartyNameHistory}} has no {{gender}} field. No confirmed caller reads this field currently.

Needs fixing: #1 fix the typo to {{partyIdFrom}}; #2 apply the same re-prepend fix to {{getChildRoleTypes}}; #3 restore the original's fixed 7-field search map instead of {{setAllFields}}; #4 source {{gender}} from the current {{Person}} record regardless of whether a historical name is shown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)