[RESULT][VOTE] Tuweni 0.8.2-incubating release

[Antoine Toulme <an...@toulme.name>]

The vote has concluded with the following results:

5 +1 votes:
Dave Fisher
Jonny Rhea
Antoine Toulme
Furkan Kamaci
Michael Wall

0 +0 votes

0 -1 votes

The release vote has passed. Thanks all!

Antoine

> On Aug 31, 2019, at 2:54 PM, Michael Wall <mj...@apache.org> wrote:
> 
> https://issues.apache.org/jira/browse/TUWENI-28
> 
> Thanks
> 
> Mike
> 
> On Sat, Aug 31, 2019 at 4:02 PM Antoine Toulme <an...@toulme.name> wrote:
> 
>> Sounds wortjy of a bug report. Please indicate your OS? At the very least
>> I’ll add more logging so we can see what port is the problem.
>> 
>>> On Aug 31, 2019, at 06:27, Michael Wall <mj...@apache.org> wrote:
>>> 
>>> +1 binding
>>> 
>>> - Signatures look good
>>> - Ran ./gradlew rat from the tag (would it make sense to be able to run
>>> from the distro)
>>> - I was unable to build, see below, but others have successfully built
>> so I
>>> don't want to hold up the build
>>> 
>>> Couple of things
>>> - LICENSE says ethereum tests are MIT (
>>> https://github.com/apache/incubator-tuweni/blob/master/LICENSE#L332) but
>>> the LICENSE file is creative commons (
>>> https://github.com/ethereum/eth2.0-tests/blob/master/LICENSE)
>>> - Unzipping the zip file I still get warned about overwriting files.
>> That
>>> seems strange, but the diff of the extracted tar.gz and extracted zip are
>>> the same.
>>> - Able to compile, but I still get the following test error.  Having
>>> trouble logging into issues.apache.org and resetting my password, but I
>>> will create a ticket this time.
>>> 
>>> ```
>>>> Task :gossip:compileTestJava
>>> Note:
>>> 
>> /home/path/tuweni-src-0.8.2/tuweni-src-0.8.2/gossip/src/test/java/org/apache/tuweni/gossip/GossipIntegrationTest.java
>>> uses or overrides a deprecated API.
>>> Note: Recompile with -Xlint:deprecation for details.
>>> 
>>>> Task :hobbits:test
>>> 
>>> org.apache.tuweni.hobbits.WebSocketTest > testTwoWSConnections(Vertx)
>> FAILED
>>>   java.net.BindException
>>>       Caused by: java.net.BindException
>>> <=======------> 60% EXECUTING [4m 36s]
>>>> :hobbits:test > 13 tests completed, 1 failed
>>>> IDLE
>>>> IDLE
>>>> IDLE
>>>> IDLE
>>>> IDLE
>>>> :hobbits:test > Executing test
>>> org.apache.tuweni.hobbits.HobbitsTransportTest
>>> ```
>>> 
>>>> On Fri, Aug 30, 2019 at 11:34 AM Michael Wall <mj...@apache.org>
>> wrote:
>>>> 
>>>> I'll make time to review tonight/tomorrow.
>>>> 
>>>> Mike
>>>> 
>>>> On Fri, Aug 30, 2019 at 11:32 AM Antoine Toulme <an...@toulme.name>
>>>> wrote:
>>>> 
>>>>> OK, I am going to wait a bit more and see if we can get one more mentor
>>>>> to weigh in. It will help with the IPMC vote on general@.
>>>>> 
>>>>>> On Aug 30, 2019, at 2:07 AM, Furkan KAMACI <fu...@gmail.com>
>>>>> wrote:
>>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> +1 from me.
>>>>>> 
>>>>>> I checked:
>>>>>> 
>>>>>> - Incubating in name
>>>>>> - DISCLAIMER exists
>>>>>> - LICENSE and NOTICE are fine
>>>>>> - No unexpected binary files
>>>>>> - Code compiles and tests successfully run
>>>>>> 
>>>>>> Kind Regards,
>>>>>> Furkan KAMACI
>>>>>> 
>>>>>> On Fri, Aug 30, 2019 at 4:13 AM Antoine Toulme <an...@toulme.name>
>>>>> wrote:
>>>>>> 
>>>>>>> I’ll cast my +1 as well.
>>>>>>> 
>>>>>>> Please make sure to review and vote if you can, I’ll close the vote
>>>>>>> tomorrow if I don’t hear anything else.
>>>>>>> 
>>>>>>>> On Aug 28, 2019, at 6:20 PM, Jonny Rhea <jo...@gmail.com>
>>>>> wrote:
>>>>>>>> 
>>>>>>>> +1
>>>>>>>> 
>>>>>>>>> On Mon, Aug 26, 2019 at 1:13 PM Dave Fisher <wa...@apache.org>
>> wrote:
>>>>>>>>> 
>>>>>>>>> +1 (binding)
>>>>>>>>> 
>>>>>>>>> - checked the detached signatures and hashes.
>>>>>>>>> - compared the content of tgz with zip and found no differences
>>>>>>>>> - check LICENSE, NOTICE, and DISCLAIMERs
>>>>>>>>> - found no unexpected binaries.
>>>>>>>>> - did a RatCheck with a .rat-excludes of *.json, *.yml, *.yaml, and
>>>>>>> *.toml
>>>>>>>>> and found nothing of concern.
>>>>>>>>> 
>>>>>>>>> Regards,
>>>>>>>>> Dave
>>>>>>>>> 
>>>>>>>>>> On Aug 26, 2019, at 2:28 AM, Antoine Toulme <an...@toulme.name>
>>>>>>> wrote:
>>>>>>>>>> 
>>>>>>>>>> We're voting on the source distributions available here:
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>> 
>>>>> 
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.8.2-incubating/
>>>>>>>>>> The release tag is present here:
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>> 
>>>>> 
>> https://github.com/apache/incubator-tuweni/releases/tag/v0.8.2-incubating
>>>>>>>>>> 
>>>>>>>>>> This release includes the following changes:
>>>>>>>>>> 
>>>>>>>>>> * Only include necessary code for testing Ethereum
>>>>>>>>>> * Fix provenance of SECP256K1 class
>>>>>>>>>> * Fix header of SECP256K1 class
>>>>>>>>>> * Fix stage task
>>>>>>>>>> * Make build reproducible
>>>>>>>>>> * Trace ProgPow algorithm in class explicitly
>>>>>>>>>> 
>>>>>>>>>> The vote is open for at least 72 hours.
>>>>>>>>>> 
>>>>>>>>>> Cheers,
>>>>>>>>>> 
>>>>>>>>>> Antoine
>>>>>>>>>> 
>>>>>>>>>> 
>>>>> ---------------------------------------------------------------------
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>> 
>>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>> 
>>>>>>> 
>>>>> 
>>>>> 
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>> 
>>>>> 
>> 
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org