You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2015/11/29 03:53:05 UTC
Review Request 40782: AMBARI-14107 Stack advisor error for
validateAmsHbaseEnvConfigurations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40782/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-14107
https://issues.apache.org/jira/browse/AMBARI-14107
Repository: ambari
Description
-------
PROBLEM
Error occured in stack advisor.
Error details: local variable 'heapPropertyToIncreaseItem' referenced before assignment
24 Nov 2015 23:20:41,541 INFO [qtp-client-29] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
main(sys.argv)
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 115, in main
result = stackAdvisor.validateConfigurations(services, hosts)
File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 463, in validateConfigurations
validationItems = self.getConfigurationsValidationItems(services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 749, in getConfigurationsValidationItems
resultItems = method(siteProperties, siteRecommendations, configurations, services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 1025, in validateAmsHbaseEnvConfigurations
if to_number(properties[heapPropertyToIncreaseItem]) < recommended_hbase_heapsize:
UnboundLocalError: local variable 'heapPropertyToIncreaseItem' referenced before assignment
BUG
Incorrect indentation and bug in stack_advisor code.
FIX
Fixed the issues with stack advisor recommendations for ams-hbase-env and cleaned up the code such that
- Add validationItems whenever they are "discovered".
- Return the first failed validation item for a property.
- Combine metrics_collector_heapsize and hbase heapsize vaildation item in the unused space on collector > 4GB case so that we can send
metrics_collector_heapsize (ams-env) validation also as part of ams-hbase-env validation items.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6031fbd
Diff: https://reviews.apache.org/r/40782/diff/
Testing
-------
Python unit tests pass.
Tested manually on big cluster to trigger execution path.
Thanks,
Aravindan Vijayan
Re: Review Request 40782: AMBARI-14107 Stack advisor error for
validateAmsHbaseEnvConfigurations
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40782/#review108263
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Nov. 29, 2015, 2:53 a.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40782/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 2:53 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-14107
> https://issues.apache.org/jira/browse/AMBARI-14107
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM
>
> Error occured in stack advisor.
> Error details: local variable 'heapPropertyToIncreaseItem' referenced before assignment
> 24 Nov 2015 23:20:41,541 INFO [qtp-client-29] StackAdvisorRunner:71 - advisor script stderr: Traceback (most recent call last):
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
> main(sys.argv)
> File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 115, in main
> result = stackAdvisor.validateConfigurations(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 463, in validateConfigurations
> validationItems = self.getConfigurationsValidationItems(services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 749, in getConfigurationsValidationItems
> resultItems = method(siteProperties, siteRecommendations, configurations, services, hosts)
> File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 1025, in validateAmsHbaseEnvConfigurations
> if to_number(properties[heapPropertyToIncreaseItem]) < recommended_hbase_heapsize:
> UnboundLocalError: local variable 'heapPropertyToIncreaseItem' referenced before assignment
>
> BUG
> Incorrect indentation and bug in stack_advisor code.
>
> FIX
> Fixed the issues with stack advisor recommendations for ams-hbase-env and cleaned up the code such that
>
> - Add validationItems whenever they are "discovered".
> - Return the first failed validation item for a property.
> - Combine metrics_collector_heapsize and hbase heapsize vaildation item in the unused space on collector > 4GB case so that we can send
> metrics_collector_heapsize (ams-env) validation also as part of ams-hbase-env validation items.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 6031fbd
>
> Diff: https://reviews.apache.org/r/40782/diff/
>
>
> Testing
> -------
>
> Python unit tests pass.
>
> Tested manually on big cluster to trigger execution path.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>