[GitHub] [iceberg] kbendick commented on a diff in pull request #5382: Core: Implement IncrementalChangelogScan without deletes

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5382:
URL: https://github.com/apache/iceberg/pull/5382#discussion_r933723830


##########
core/src/main/java/org/apache/iceberg/BaseIncrementalChangelogScan.java:
##########
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import java.util.ArrayDeque;
+import java.util.Deque;
+import java.util.Map;
+import java.util.Set;
+import java.util.stream.Collectors;
+import org.apache.iceberg.ManifestGroup.CreateTasksFunction;
+import org.apache.iceberg.ManifestGroup.TaskContext;
+import org.apache.iceberg.io.CloseableIterable;
+import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.collect.FluentIterable;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.apache.iceberg.util.SnapshotUtil;
+import org.apache.iceberg.util.TableScanUtil;
+
+class BaseIncrementalChangelogScan
+    extends BaseIncrementalScan<
+        IncrementalChangelogScan, ChangelogScanTask, ScanTaskGroup<ChangelogScanTask>>

Review Comment:
   I find that sometimes if it changes something I've written that I really dislike (especially extends statements), I can try to fix it a bit and rerun spotless apply and it will usually let me do something better than what it chose to do at first.
   
   Breaking the type parameter of `BaseIncrementalScan` at the `<` across lines is somewhat of a visual sin (which I know you didn't choose to do 😜 ).



##########
api/src/main/java/org/apache/iceberg/Scan.java:
##########
@@ -137,6 +144,14 @@
    */
   CloseableIterable<G> planTasks();
 
+  /**
+   * Returns whether this scan should apply column name case sensitiveness as per {@link
+   * Scan#caseSensitive(boolean)}.

Review Comment:
   Nit: maybe `Return whether this scan should be case sensitive with respect to column names` or something else that avoids the phrase `apply column name case sensitiveness`. Even just avoiding `case sensitiveness` would help me to think less about it when looking through it.
   
   EDiT - I see this is the same wording carried from `TableScan`. Would not advise changing for this reason alone then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org