You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2021/01/11 17:32:54 UTC
[Issue 125129] Writer: Insert->Frame->Area crashes
https://bz.apache.org/ooo/show_bug.cgi?id=125129
Arrigo Marchiori <ar...@yahoo.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ardovm@yahoo.it
--- Comment #23 from Arrigo Marchiori <ar...@yahoo.it> ---
Trying to take advantage of the excellent debugging work Damjan carried out
with the help of Matthias, I tried to find the smallest possible solution to
this problem.
I must admit I am not very sure I understood what SfxItemSets are... but the
pull request I just opened _seems_ to fix the problem:
https://github.com/apache/openoffice/pull/118
I started from the observation that editing an existing frame worked, and I
looked for the piece of code that does that job. It appears to be in file
main/sw/source/ui/shells/frmsh.cxx starting at line 422.
The first most relevant difference with main/sw/source/ui/shells/textsh.cxx:598
is that the SfxItemSets passed contained less "ranges". Moreover the comments
from the ``working'' code seem to suggest that some items must be initialized
in a certain way.
I just copied and pasted those bits, and now it seems to work.
Incidentally, I had initially only added the ColorTableItem. This fixed the
crash but the dialog crashed when I selected a gradient.
Then I understood I also had to provide the gradients, hatches and bitmaps.
But then any settings I selected was not transferred to the new object.
I copied all the ranges, and this seems to have fixed the problem.
--
You are receiving this mail because:
You are the assignee for the issue.