You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/04/09 05:54:20 UTC
[GitHub] [incubator-hudi] modi95 opened a new pull request #1501: [HUDI-601]
Improve unit test coverage for HoodieAvroWriteSupport,
HoodieRealtimeRecordReader, RealtimeCompactedRecordReader
modi95 opened a new pull request #1501: [HUDI-601] Improve unit test coverage for HoodieAvroWriteSupport, HoodieRealtimeRecordReader, RealtimeCompactedRecordReader
URL: https://github.com/apache/incubator-hudi/pull/1501
NOTE - this is a copy of https://github.com/apache/incubator-hudi/pull/1310/
Raises unit test coverage for the following classes:
- org.apache.hudi.avro.HoodieAvroWriteSupport
- org.apache.hudi.hadoop.realtime.HoodieRealtimeRecordReader
- org.apache.hudi.hadoop.realtime.RealtimeCompactedRecordReader
This PR does not add any new logic - it simply improves unit test coverage
## Committer checklist
- [x] Has a corresponding JIRA in PR title & commit
- [x] Commit message is descriptive of the change
- [x] CI is green
- [x] Necessary doc changes done or have another open PR
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io commented on issue #1501: [HUDI-601]
Improve unit test coverage for HoodieAvroWriteSupport,
HoodieRealtimeRecordReader, RealtimeCompactedRecordReader
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1501: [HUDI-601] Improve unit test coverage for HoodieAvroWriteSupport, HoodieRealtimeRecordReader, RealtimeCompactedRecordReader
URL: https://github.com/apache/incubator-hudi/pull/1501#issuecomment-611355603
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1501?src=pr&el=h1) Report
> Merging [#1501](https://codecov.io/gh/apache/incubator-hudi/pull/1501?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/3c803421e0e138c223c9bec90f9b7c8a6751317d&el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1501/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/incubator-hudi/pull/1501?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1501 +/- ##
============================================
+ Coverage 71.64% 71.81% +0.17%
Complexity 290 290
============================================
Files 338 338
Lines 15931 15931
Branches 1625 1625
============================================
+ Hits 11413 11441 +28
+ Misses 3785 3758 -27
+ Partials 733 732 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1501?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...mmon/table/log/AbstractHoodieLogRecordScanner.java](https://codecov.io/gh/apache/incubator-hudi/pull/1501/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL2xvZy9BYnN0cmFjdEhvb2RpZUxvZ1JlY29yZFNjYW5uZXIuamF2YQ==) | `86.99% <0.00%> (+0.81%)` | `0.00% <0.00%> (ø%)` | |
| [.../apache/hudi/hadoop/RecordReaderValueIterator.java](https://codecov.io/gh/apache/incubator-hudi/pull/1501/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL1JlY29yZFJlYWRlclZhbHVlSXRlcmF0b3IuamF2YQ==) | `79.16% <0.00%> (+8.33%)` | `0.00% <0.00%> (ø%)` | |
| [...hadoop/realtime/RealtimeCompactedRecordReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1501/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL1JlYWx0aW1lQ29tcGFjdGVkUmVjb3JkUmVhZGVyLmphdmE=) | `72.34% <0.00%> (+8.51%)` | `0.00% <0.00%> (ø%)` | |
| [.../hadoop/realtime/RealtimeUnmergedRecordReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1501/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL1JlYWx0aW1lVW5tZXJnZWRSZWNvcmRSZWFkZXIuamF2YQ==) | `96.96% <0.00%> (+12.12%)` | `0.00% <0.00%> (ø%)` | |
| [...src/main/java/org/apache/hudi/metrics/Metrics.java](https://codecov.io/gh/apache/incubator-hudi/pull/1501/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `72.22% <0.00%> (+13.88%)` | `0.00% <0.00%> (ø%)` | |
| [...he/hudi/hadoop/SafeParquetRecordReaderWrapper.java](https://codecov.io/gh/apache/incubator-hudi/pull/1501/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL1NhZmVQYXJxdWV0UmVjb3JkUmVhZGVyV3JhcHBlci5qYXZh) | `92.85% <0.00%> (+21.42%)` | `0.00% <0.00%> (ø%)` | |
| [...di/hadoop/realtime/HoodieRealtimeRecordReader.java](https://codecov.io/gh/apache/incubator-hudi/pull/1501/diff?src=pr&el=tree#diff-aHVkaS1oYWRvb3AtbXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvaGFkb29wL3JlYWx0aW1lL0hvb2RpZVJlYWx0aW1lUmVjb3JkUmVhZGVyLmphdmE=) | `84.21% <0.00%> (+36.84%)` | `0.00% <0.00%> (ø%)` | |
| [...g/apache/hudi/metrics/InMemoryMetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1501/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9Jbk1lbW9yeU1ldHJpY3NSZXBvcnRlci5qYXZh) | `80.00% <0.00%> (+40.00%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1501?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1501?src=pr&el=footer). Last update [3c80342...ce23431](https://codecov.io/gh/apache/incubator-hudi/pull/1501?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] n3nash merged pull request #1501: [HUDI-601]
Improve unit test coverage for HoodieAvroWriteSupport,
HoodieRealtimeRecordReader, RealtimeCompactedRecordReader
Posted by GitBox <gi...@apache.org>.
n3nash merged pull request #1501: [HUDI-601] Improve unit test coverage for HoodieAvroWriteSupport, HoodieRealtimeRecordReader, RealtimeCompactedRecordReader
URL: https://github.com/apache/incubator-hudi/pull/1501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services