You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/04/28 06:46:13 UTC
[GitHub] [incubator-hugegraph-toolchain] imbajin opened a new pull request, #268: chore: adopt to run actions in toolchain
imbajin opened a new pull request, #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268
This pr test the ci problems in #267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#discussion_r861445631
##########
assembly/descriptor/assembly.xml:
##########
@@ -0,0 +1,54 @@
+<assembly>
+ <id>distribution</id>
+ <includeBaseDirectory>false</includeBaseDirectory>
+
+ <formats>
+ <format>dir</format>
+ </formats>
+
+ <fileSets>
+ <fileSet>
+ <directory>${assembly.static.dir}/bin</directory>
+ <outputDirectory>bin</outputDirectory>
+ <includes>
+ <include>*</include>
+ </includes>
+ <fileMode>755</fileMode>
+ </fileSet>
+ <fileSet>
+ <directory>${assembly.static.dir}</directory>
+ <outputDirectory>/</outputDirectory>
+ <filtered>false</filtered>
+ </fileSet>
+ <fileSet>
+ <directory>${project.basedir}</directory>
+ <outputDirectory>/</outputDirectory>
+ <includes>
+ <include>README*</include>
+ <include>LICENSE*</include>
+ <include>NOTICE*</include>
+ </includes>
+ </fileSet>
+ <fileSet>
+ <directory>${project.build.directory}</directory>
+ <outputDirectory>lib</outputDirectory>
+ <includes>
+ <include>*.jar</include>
+ </includes>
+ </fileSet>
+ </fileSets>
+
+ <dependencySets>
+ <!-- Code jars -->
+ <dependencySet>
+ <outputDirectory>/lib</outputDirectory>
+ <unpack>false</unpack>
+ <scope>runtime</scope>
+ <useProjectArtifact>false</useProjectArtifact>
+ <includes>
+ <include>*:*:jar:*</include>
+ </includes>
+ </dependencySet>
+ </dependencySets>
+
+</assembly>
Review Comment:
expect a newline
##########
.github/workflows/loader-ci.yml:
##########
@@ -0,0 +1,86 @@
+name: hugegraph-loader-ci
+
+on:
+ push:
+ branches:
+ - master
+ - /^release-.*$/
+ - /^test-.*$/
+ paths:
+ - hugegraph-loader/**
+ - pom.xml
+ pull_request:
+ branches:
+ - master
+ - /^release-.*$/
+ - /^test-.*$/
+ paths:
+ - hugegraph-loader/**
+ - pom.xml
+
+jobs:
+ build:
+ runs-on: ubuntu-20.04
+ env:
+ TRAVIS_DIR: hugegraph-loader/assembly/travis
+ STATIC_DIR: hugegraph-loader/assembly/static
+ COMMIT_ID: 1d031c5905cbef008dd5fb468576b0e6a9445181
+ DB_USER: root
+ DB_PASS: root
+ DB_DATABASE: load_test
+ steps:
+ - name: Install JDK 8
+ uses: actions/setup-java@v2
+ with:
+ java-version: '8'
+ distribution: 'zulu'
+
+ - name: Cache Maven packages
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 2
+
+ - name: Compile
+ run: |
+ mvn install:install-file -Dfile=$STATIC_DIR/lib/ojdbc8-12.2.0.1.jar -DgroupId=com.oracle -DartifactId=ojdbc8 -Dversion=12.2.0.1 -Dpackaging=jar
+ cd hugegraph-loader && ls *
+ mvn -e compile -Dmaven.javadoc.skip=true | grep -v "Downloading\|Downloaded"
+
+# - name: Init Mysql Env
+# uses: mirromutth/mysql-action@v1.1
+# with:
+# host port: 3306 # Optional, default value is 3306. The port of host
+# container port: 3306 # Optional, default value is 3306. The port of container
+# character set server: 'utf8mb4' # Optional, default value is 'utf8mb4'. The '--character-set-server' option for mysqld
+# collation server: 'utf8mb4_general_ci' # Optional, default value is 'utf8mb4_general_ci'. The '--collation-server' option for mysqld
+# mysql version: '5.7' # Optional, default value is "latest". The version of the MySQL
+# mysql database: ${{ env.DB_DATABASE }} # Optional, default value is "test". The specified database which will be create
+# mysql root password: ${{ env.DB_PASS }} # Required if "mysql user" is empty, default is empty. The root superuser password
+# #mysql user: 'root' # Required if "mysql root password" is empty, default is empty. The superuser for the specified database. Can use secrets, too
+# #mysql password: ${{ secrets.DatabasePassword }} # Required if "mysql user" exists. The password for the "mysql user"
Review Comment:
can delete these useless code
##########
hugegraph-loader/assembly/travis/install-mysql.sh:
##########
@@ -2,22 +2,36 @@
set -ev
-TRAVIS_DIR=`dirname $0`
+TRAVIS_DIR=$(dirname $0)
+
+# Need speed up it
+CONF=hugegraph-test/src/main/resources/hugegraph.properties
+MYSQL_USERNAME=root
+
+# Set MySQL configurations
Review Comment:
no content for this section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] z7658329 commented on pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
z7658329 commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1113184132
>
i will test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
javeme commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1112935005
ci error:
```java
cp "${TRAVIS_DIR}"/jacocoagent.jar hugegraph-hubble-*/lib || exit 1
cp: cannot create regular file 'hugegraph-hubble-*/lib': No such file or directory
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#discussion_r861504055
##########
hugegraph-loader/assembly/travis/install-mysql.sh:
##########
@@ -2,22 +2,36 @@
set -ev
-TRAVIS_DIR=`dirname $0`
+TRAVIS_DIR=$(dirname $0)
+
+# Need speed up it
+CONF=hugegraph-test/src/main/resources/hugegraph.properties
+MYSQL_USERNAME=root
+
+# Set MySQL configurations
Review Comment:
seems no need now, could remove it or keep the comment for future use
##########
hugegraph-loader/assembly/travis/install-mysql.sh:
##########
@@ -2,22 +2,36 @@
set -ev
-TRAVIS_DIR=`dirname $0`
+TRAVIS_DIR=$(dirname $0)
+
+# Need speed up it
+CONF=hugegraph-test/src/main/resources/hugegraph.properties
+MYSQL_USERNAME=root
+
+# Set MySQL configurations
Review Comment:
seems no need now, could remove it or keep the comment for future use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] codecov[bot] commented on pull request #268: chore: adopt to run actions in toolchain
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1111877532
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/268?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@025c5ab`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #268 +/- ##
=========================================
Coverage ? 73.54%
Complexity ? 876
=========================================
Files ? 81
Lines ? 3689
Branches ? 439
=========================================
Hits ? 2713
Misses ? 777
Partials ? 199
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/268?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/268?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [025c5ab...6b37147](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/268?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] z7658329 commented on pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
z7658329 commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1122021483
> @z7658329 the hubble build problem will fix in another pr, any problems in other modules now?
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1120368295
@z7658329 the hubble build problem will fix in another pr, any problems in other modules now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#discussion_r861503393
##########
.github/workflows/loader-ci.yml:
##########
@@ -0,0 +1,86 @@
+name: hugegraph-loader-ci
+
+on:
+ push:
+ branches:
+ - master
+ - /^release-.*$/
+ - /^test-.*$/
+ paths:
+ - hugegraph-loader/**
+ - pom.xml
+ pull_request:
+ branches:
+ - master
+ - /^release-.*$/
+ - /^test-.*$/
+ paths:
+ - hugegraph-loader/**
+ - pom.xml
+
+jobs:
+ build:
+ runs-on: ubuntu-20.04
+ env:
+ TRAVIS_DIR: hugegraph-loader/assembly/travis
+ STATIC_DIR: hugegraph-loader/assembly/static
+ COMMIT_ID: 1d031c5905cbef008dd5fb468576b0e6a9445181
+ DB_USER: root
+ DB_PASS: root
+ DB_DATABASE: load_test
+ steps:
+ - name: Install JDK 8
+ uses: actions/setup-java@v2
+ with:
+ java-version: '8'
+ distribution: 'zulu'
+
+ - name: Cache Maven packages
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 2
+
+ - name: Compile
+ run: |
+ mvn install:install-file -Dfile=$STATIC_DIR/lib/ojdbc8-12.2.0.1.jar -DgroupId=com.oracle -DartifactId=ojdbc8 -Dversion=12.2.0.1 -Dpackaging=jar
+ cd hugegraph-loader && ls *
+ mvn -e compile -Dmaven.javadoc.skip=true | grep -v "Downloading\|Downloaded"
+
+# - name: Init Mysql Env
+# uses: mirromutth/mysql-action@v1.1
+# with:
+# host port: 3306 # Optional, default value is 3306. The port of host
+# container port: 3306 # Optional, default value is 3306. The port of container
+# character set server: 'utf8mb4' # Optional, default value is 'utf8mb4'. The '--character-set-server' option for mysqld
+# collation server: 'utf8mb4_general_ci' # Optional, default value is 'utf8mb4_general_ci'. The '--collation-server' option for mysqld
+# mysql version: '5.7' # Optional, default value is "latest". The version of the MySQL
+# mysql database: ${{ env.DB_DATABASE }} # Optional, default value is "test". The specified database which will be create
+# mysql root password: ${{ env.DB_PASS }} # Required if "mysql user" is empty, default is empty. The root superuser password
+# #mysql user: 'root' # Required if "mysql root password" is empty, default is empty. The superuser for the specified database. Can use secrets, too
+# #mysql password: ${{ secrets.DatabasePassword }} # Required if "mysql user" exists. The password for the "mysql user"
Review Comment:
maybe it's useful in future, but delete it anyway..
##########
.github/workflows/loader-ci.yml:
##########
@@ -0,0 +1,86 @@
+name: hugegraph-loader-ci
+
+on:
+ push:
+ branches:
+ - master
+ - /^release-.*$/
+ - /^test-.*$/
+ paths:
+ - hugegraph-loader/**
+ - pom.xml
+ pull_request:
+ branches:
+ - master
+ - /^release-.*$/
+ - /^test-.*$/
+ paths:
+ - hugegraph-loader/**
+ - pom.xml
+
+jobs:
+ build:
+ runs-on: ubuntu-20.04
+ env:
+ TRAVIS_DIR: hugegraph-loader/assembly/travis
+ STATIC_DIR: hugegraph-loader/assembly/static
+ COMMIT_ID: 1d031c5905cbef008dd5fb468576b0e6a9445181
+ DB_USER: root
+ DB_PASS: root
+ DB_DATABASE: load_test
+ steps:
+ - name: Install JDK 8
+ uses: actions/setup-java@v2
+ with:
+ java-version: '8'
+ distribution: 'zulu'
+
+ - name: Cache Maven packages
+ uses: actions/cache@v2
+ with:
+ path: ~/.m2
+ key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
+ restore-keys: ${{ runner.os }}-m2
+
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 2
+
+ - name: Compile
+ run: |
+ mvn install:install-file -Dfile=$STATIC_DIR/lib/ojdbc8-12.2.0.1.jar -DgroupId=com.oracle -DartifactId=ojdbc8 -Dversion=12.2.0.1 -Dpackaging=jar
+ cd hugegraph-loader && ls *
+ mvn -e compile -Dmaven.javadoc.skip=true | grep -v "Downloading\|Downloaded"
+
+# - name: Init Mysql Env
+# uses: mirromutth/mysql-action@v1.1
+# with:
+# host port: 3306 # Optional, default value is 3306. The port of host
+# container port: 3306 # Optional, default value is 3306. The port of container
+# character set server: 'utf8mb4' # Optional, default value is 'utf8mb4'. The '--character-set-server' option for mysqld
+# collation server: 'utf8mb4_general_ci' # Optional, default value is 'utf8mb4_general_ci'. The '--collation-server' option for mysqld
+# mysql version: '5.7' # Optional, default value is "latest". The version of the MySQL
+# mysql database: ${{ env.DB_DATABASE }} # Optional, default value is "test". The specified database which will be create
+# mysql root password: ${{ env.DB_PASS }} # Required if "mysql user" is empty, default is empty. The root superuser password
+# #mysql user: 'root' # Required if "mysql root password" is empty, default is empty. The superuser for the specified database. Can use secrets, too
+# #mysql password: ${{ secrets.DatabasePassword }} # Required if "mysql user" exists. The password for the "mysql user"
Review Comment:
maybe it's useful in future, but delete it anyway..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] z7658329 commented on pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
z7658329 commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1120338904
> > skip due to packaging 'jar'
>
> seems it was also `jar` mode before, and what will happens if it run in `hubble` dir (not `be`)?
result:
<img width="1322" alt="image" src="https://user-images.githubusercontent.com/5474723/167279704-fb6edb02-43a8-432f-b6f0-d4b785fcf8bd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] corgiboygsj merged pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
corgiboygsj merged PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] z7658329 commented on pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
z7658329 commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1112347052
zoulei@zouleis-MacBook-Air hubble-be % mvn license:aggregate-add-third-party
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< org.apache.hugegraph:hubble-be >-------------------
[INFO] Building hubble-be 1.0.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- license-maven-plugin:1.19:aggregate-add-third-party (default-cli) @ hubble-be ---
[WARNING] The goal is skip due to packaging 'jar'
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.179 s
[INFO] Finished at: 2022-04-28T23:26:08+08:00
[INFO] ------------------------------------------------------------------------
zoulei@zouleis-MacBook-Air hubble-be %
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1112934680
> skip due to packaging 'jar'
seems it was also `jar` mode before, and what will happens if it run in `hubble` dir (not `be`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#discussion_r861538473
##########
hugegraph-hubble/hubble-dist/assembly/travis/run-api-test.sh:
##########
@@ -2,8 +2,11 @@
set -ev
-"$TRAVIS_DIR"/install-hugegraph-hubble.sh
+EXEC_PATH="hubble-dist/assembly/travis"
Review Comment:
keep "TRAVIS_DIR" style
##########
hugegraph-hubble/hubble-dist/assembly/travis/install-hugegraph-hubble.sh:
##########
@@ -4,9 +4,10 @@ set -ev
TRAVIS_DIR=$(dirname "$0")
-mvn -e clean package -DskipTests
+echo "$TRAVIS_DIR"
+pwd && mvn -e -X clean package -DskipTests
-cp "${TRAVIS_DIR}"/jacocoagent.jar hugegraph-hubble-*/lib
-cp "${TRAVIS_DIR}"/start-hubble.sh hugegraph-hubble-*/bin
+cp "${TRAVIS_DIR}"/jacocoagent.jar hugegraph-hubble-*/lib || exit 1
Review Comment:
add `HUBBLE_DIR=$(echo hugegraph-hubble-*.*)` and use `${HUBBLE_DIR}/lib`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on pull request #268: refact: adopt all modules run actions well in toolchain & enhance the ci logic
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #268:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/268#issuecomment-1118412815
separate hubble build package **problem** in another PR for ci running first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org