You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/11/17 18:44:14 UTC

[GitHub] [trafficserver] SolidWallOfCode opened a new pull request, #9203: libswoc - replace string_view_util with libswoc version.

SolidWallOfCode opened a new pull request, #9203:
URL: https://github.com/apache/trafficserver/pull/9203

   This is needed both to remove redundancy and to avoid circular dependencies, as libswoc internals depend on the functions in the `string_view` utils.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9203: libswoc - replace string_view_util with libswoc version.

Posted by GitBox <gi...@apache.org>.

SolidWallOfCode commented on PR #9203:
URL: https://github.com/apache/trafficserver/pull/9203#issuecomment-1319470915

   Seriously? That was the fix? Gah.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9203: libswoc - replace string_view_util with libswoc version.

Posted by GitBox <gi...@apache.org>.

SolidWallOfCode commented on PR #9203:
URL: https://github.com/apache/trafficserver/pull/9203#issuecomment-1319448508

   [approve ci rocky]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode merged pull request #9203: libswoc - replace string_view_util with libswoc version.

Posted by GitBox <gi...@apache.org>.

SolidWallOfCode merged PR #9203:
URL: https://github.com/apache/trafficserver/pull/9203


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9203: libswoc - replace string_view_util with libswoc version.

Posted by GitBox <gi...@apache.org>.

SolidWallOfCode commented on PR #9203:
URL: https://github.com/apache/trafficserver/pull/9203#issuecomment-1319483190

   Seriously? That fix worked? Gaaaaaaaaaaaaaaaaaaaaaaah!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on pull request #9203: libswoc - replace string_view_util with libswoc version.

Posted by GitBox <gi...@apache.org>.

bneradt commented on PR #9203:
URL: https://github.com/apache/trafficserver/pull/9203#issuecomment-1319116739

   The builds are failing due to linking issues. Here's a link to the Ubuntu failure:
   https://ci.trafficserver.apache.org/job/Github_Builds/job/ubuntu/389/console
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9203: libswoc - replace string_view_util with libswoc version.

Posted by GitBox <gi...@apache.org>.

SolidWallOfCode commented on PR #9203:
URL: https://github.com/apache/trafficserver/pull/9203#issuecomment-1319132971

   Oh, I'm tracking the linking issues. The problem is all of that works perfectly locally. This is part of resolving the linking issues with #9193 .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bneradt commented on a diff in pull request #9203: libswoc - replace string_view_util with libswoc version.

Posted by GitBox <gi...@apache.org>.

bneradt commented on code in PR #9203:
URL: https://github.com/apache/trafficserver/pull/9203#discussion_r1025627504


##########
lib/swoc/include/swoc/string_view_util.h:
##########
@@ -85,15 +74,14 @@ strcmp(const std::string_view &lhs, const std::string_view &rhs)
  * @code
  *   memcpy(dst, src.data(), size.size());
  * @endcode
- * Therefore @a dst must point at a buffer large enough to hold @a src. If this is not already
+ * Therefore @a dst must point at a buffer large enought to hold @a src. If this is not already

Review Comment:
   enought



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9203: libswoc - replace string_view_util with libswoc version.

Posted by GitBox <gi...@apache.org>.

SolidWallOfCode commented on PR #9203:
URL: https://github.com/apache/trafficserver/pull/9203#issuecomment-1319105703

   [approve ci fedora]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org