You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (Jira)" <ji...@apache.org> on 2020/07/03 09:30:00 UTC
[jira] [Commented] (FLINK-17085) Remove
FlinkKubeClient#handleException since it does not do anything
[ https://issues.apache.org/jira/browse/FLINK-17085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150864#comment-17150864 ]
Chesnay Schepler commented on FLINK-17085:
------------------------------------------
Sounds good [~fly_in_gis], will you work on it?
> Remove FlinkKubeClient#handleException since it does not do anything
> --------------------------------------------------------------------
>
> Key: FLINK-17085
> URL: https://issues.apache.org/jira/browse/FLINK-17085
> Project: Flink
> Issue Type: Task
> Components: Deployment / Kubernetes
> Reporter: Yang Wang
> Priority: Minor
>
> Follow up the discussion in this PR[1].
> Currently, {{FlinkKubeClient#handleException}} just log the exception and do not have any substantial operations. Since all the exception has already been handled, for example, {{KubernetesClusterDescriptor#createClusterClientProvider #killCluster}}, then it should be removed.
> Moreover, the {{handleException}} will cause the exception duplication in CLI.
>
> [1]. [https://github.com/apache/flink/pull/11427#discussion_r404221581]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)