You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/10 11:50:34 UTC
[GitHub] [tvm] elvin-n opened a new pull request #8981: Fix test to reflect change of simd size for ARM
elvin-n opened a new pull request #8981:
URL: https://github.com/apache/tvm/pull/8981
Fixed below tests:
```
FAILED tests/python/relay/aot/test_crt_aot.py::test_memory_planning[8-10368-15392]
FAILED tests/python/relay/aot/test_crt_aot.py::test_memory_planning[16-10368-15424]
FAILED tests/python/relay/aot/test_crt_aot.py::test_memory_planning[256-10752-17664]
```
Root cause: after adding of big number x86 cpu from LLVM to topi logic and the change of the `get_simd_32bit_lanes()` logic to return default SIMD size to 128bit value, the tests appeared after creation of int8 AVX2 PR and which passed with previous default value started to fail after int8 AVX2 merge
The 128 is a correct value for ARM, need to change the test, not the default value in get_simd_32bit_lanes()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] elvin-n commented on pull request #8981: Fix test to reflect change of simd size for ARM
Posted by GitBox <gi...@apache.org>.
elvin-n commented on pull request #8981:
URL: https://github.com/apache/tvm/pull/8981#issuecomment-916845951
@Mousius and @manupa-arm could you please verify that values are correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] elvin-n commented on pull request #8981: Fix test to reflect change of simd size for ARM
Posted by GitBox <gi...@apache.org>.
elvin-n commented on pull request #8981:
URL: https://github.com/apache/tvm/pull/8981#issuecomment-917218275
patch was integrated into PR8980, close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] u99127 commented on pull request #8981: Fix test to reflect change of simd size for ARM
Posted by GitBox <gi...@apache.org>.
u99127 commented on pull request #8981:
URL: https://github.com/apache/tvm/pull/8981#issuecomment-916877279
128 is correct for Advanced SIMD i.e. the SIMD unit in Cortex-A CPUs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #8981: Fix test to reflect change of simd size for ARM
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8981:
URL: https://github.com/apache/tvm/pull/8981#issuecomment-916985281
@elvin-n do you mind tagging the PRs you mentioned above here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] elvin-n closed pull request #8981: Fix test to reflect change of simd size for ARM
Posted by GitBox <gi...@apache.org>.
elvin-n closed pull request #8981:
URL: https://github.com/apache/tvm/pull/8981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org